mihaibudiu commented on code in PR #5200:
URL: https://github.com/apache/calcite/pull/5200#discussion_r3824668799
##########
linq4j/src/main/java/org/apache/calcite/linq4j/tree/BlockBuilder.java:
##########
@@ -603,15 +605,64 @@ private static class InlineVariableVisitor extends
SubstituteVariableVisitor {
/** Use counter. */
private static class UseCounter extends VisitorImpl<Void> {
- private final IdentityHashMap<ParameterExpression, Slot> map = new
IdentityHashMap<>();
+ /** Map each parameter to information about how it is used. */
+ private final IdentityHashMap<ParameterExpression, ParameterUse> map = new
IdentityHashMap<>();
Review Comment:
I have found while loops, so they are used. I will submit a commit handling
these as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
