skrcode opened a new pull request, #5212: URL: https://github.com/apache/calcite/pull/5212
Follow-up to #5204, requested by @rubenada in https://github.com/apache/calcite/pull/5204#issuecomment-5385243886. This adds direct regression tests for the three CALCITE-7731 plain-notation guards outside the parser path: - RexBuilder.makeLiteral with a dialect-permitted negative DECIMAL scale - Rel-to-SQL conversion of an oversized exact DECIMAL literal - SqlNumericLiteral.toValue for a directly constructed literal Each test uses a bounded input of roughly 20,000 digits and verifies the specific guard exception. No production code changes are included. Validation on current main with Java 21 and the pinned Gradle 8.14.4 wrapper: - focused new tests: 3 passed, 0 failed - RelToSqlConverterTest: 623 passed, 0 failed - RexBuilderTest: 72 passed, 0 failed - SqlNodeTest: 4 passed, 0 failed - core Checkstyle and AutoStyle: passed - :core:build: 16,658 completed, 0 failed, 155 skipped - repository-wide build: BUILD SUCCESSFUL, 413 tasks The initial missing cases were identified by JAIPilot Cloud, then rebased, reviewed, and independently validated against the latest upstream main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
