gianm opened a new pull request, #5368: URL: https://github.com/apache/calcite/pull/5368
In `RelDecorrelator`, the flag `parentPropagatesNullValues` controls whether `rewriteScalarAggregate` is skipped. It was handled incorrectly in two cases: 1. The flag from the parent should not have been passed down to the right side. (The right side only needs to know whether the join is LEFT.) 2. Decorrelate of Sort should pass the flag down, rather than always setting it to `true`. In `TopDownGeneralDecorrelator`, the flag `allowEmptyOutputFromRewrite` serves a similar purpose and was set based on `joinType != LEFT_MARK`. This allowed `INNER` which is incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
