vlsi commented on PR #5375: URL: https://github.com/apache/calcite/pull/5375#issuecomment-6522872179
> PR description: Replace the regex with a **linear** wildcard-matching algorithm Matching is `O(n·m)` in the worst case (`n` is the name length, `m` the pattern length), not linear; for example, `%aaa…ab%` against `aaa…a` compares up to `m` characters at each of `n` positions. That is fine for schema, table, and column names, so I suggest updating PR description. As a hardening, we could add a hard limit for the pattern length (e.g. 1024 chars) in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
