linzch3 opened a new pull request, #5389: URL: https://github.com/apache/calcite/pull/5389
## Jira Link [CALCITE-7877](https://issues.apache.org/jira/browse/CALCITE-7877) ## Changes Proposed `EnumerableDefaults.asOrderedQueryable` passed `requireNonNull(null, "null")` as the `QueryProvider`, so wrapping any plain `Enumerable` threw an NPE. That also broke the four `orderBy` / `orderByDescending` overloads of `EnumerableQueryable`, which all go through it. It now uses `Linq4j.DEFAULT_PROVIDER`, the same provider `Extensions.asQueryable` already uses when it wraps an `Enumerable`. Added a test in `Linq4jTest` covering the direct call and the `orderBy` / `orderByDescending` paths; it fails with the NPE without the fix. One thing I wasn't sure about: for `EnumerableQueryable.orderBy*` it might be nicer to keep the original queryable's provider instead of falling back to the default one. I kept the smaller change since that matches the pre-1.27 behavior (null provider) more closely, but happy to change it. AI-assisted, reviewed by me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
