vldpyatkov commented on code in PR #5393:
URL: https://github.com/apache/calcite/pull/5393#discussion_r4507572897
##########
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##########
@@ -5424,6 +5424,36 @@ private static class BothValuesAreNullException extends
RuntimeException {
}
}
+ /** Variant of {@link #compareNullsLastForMergeJoin(Comparable, Comparable,
Comparator)}
+ * for values that are not {@link Comparable}, such as ROW and ARRAY values.
+ * Throws {@link BothValuesAreNullException} if both values are null. */
+ public static <T> int compareObjectsNullsLastForMergeJoin(@Nullable T v0,
Review Comment:
The three-argument overload was unused after the refactoring, so I've
removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
