astefanutti commented on pull request #1816: URL: https://github.com/apache/camel-k/pull/1816#issuecomment-764797344
@doru1004 thanks, that looks good to me from an end-user standpoint. From the implementation, I would suggest to try reusing the builder API for local operations as much as possible, and avoid duplicating code to create the Maven project and perform build commands. FWIW, the builder API entry point is: https://github.com/apache/camel-k/blob/5b08073054a43ee170e48e2e8329826a30984e42/pkg/builder/builder.go#L51 It already provides a way to specify the build directory: https://github.com/apache/camel-k/blob/5b08073054a43ee170e48e2e8329826a30984e42/pkg/builder/builder.go#L55 The builder is already used to perform builds: - In a Go routine from the operator process: https://github.com/apache/camel-k/blob/5b08073054a43ee170e48e2e8329826a30984e42/pkg/controller/build/schedule_routine.go#L139 - In container scheduled by the operator: https://github.com/apache/camel-k/blob/5b08073054a43ee170e48e2e8329826a30984e42/pkg/cmd/builder/builder.go#L83 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
