davsclaus commented on a change in pull request #5088:
URL: https://github.com/apache/camel/pull/5088#discussion_r576084869



##########
File path: 
core/camel-core-model/src/main/java/org/apache/camel/model/RoutesDefinition.java
##########
@@ -192,9 +192,18 @@ public RouteDefinition from(EndpointConsumerBuilder 
endpoint) {
      * @return       the builder
      */
     public RouteDefinition route(RouteDefinition route) {
+        // must set the error handler if not already set on the route
+        if (route.getErrorHandlerFactory() != null && 
route.getErrorHandlerRef() != null) {
+            ErrorHandlerFactory handler = getErrorHandlerFactory();
+            if (handler != null) {
+                route.setErrorHandlerFactory(handler);
+            }
+        }

Review comment:
       No it looks good




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to