astefanutti commented on a change in pull request #2421:
URL: https://github.com/apache/camel-k/pull/2421#discussion_r655216715
##########
File path: pkg/trait/deployer.go
##########
@@ -96,6 +96,8 @@ func (t *deployerTrait) Apply(e *Environment) error {
} else if
isIncompatibleServerError(err) {
t.L.Info("Fallback to
client-side apply to patch resources")
hasServerSideApply = false
+ } else {
+ t.L.Info("Failed with
server-side apply due to: %v", err.Error())
Review comment:
That's a very good catch. In that case, what about returning the error,
and let the controller log the message and requeue the request? CSA support is
mainly kept for compatibility reason, and will ultimately be removed, so it
should only be used as fallback when SSA is known to be unavailable, not in the
general case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
