astefanutti commented on a change in pull request #2635:
URL: https://github.com/apache/camel-k/pull/2635#discussion_r716525576
##########
File path: docs/modules/traits/pages/configuration.adoc
##########
@@ -0,0 +1,36 @@
+= Configuration Trait
Review comment:
It seems that file should be removed?
##########
File path: pkg/trait/camel.go
##########
@@ -73,6 +80,17 @@ func (t *camelTrait) Apply(e *Environment) error {
e.IntegrationKit.Status.RuntimeProvider =
e.CamelCatalog.Runtime.Provider
}
+ if e.InPhase(v1.IntegrationKitPhaseReady, v1.IntegrationPhaseDeploying)
||
Review comment:
```suggestion
if e.IntegrationKitInPhase(v1.IntegrationKitPhaseReady) &&
e.IntegrationInRunningPhases() {
```
##########
File path: docs/modules/traits/pages/runtime.adoc
##########
@@ -0,0 +1,36 @@
+= Runtime Trait
Review comment:
It seems that file should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]