davsclaus commented on a change in pull request #6669:
URL: https://github.com/apache/camel/pull/6669#discussion_r779798482
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,11 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <scope>test</scope>
Review comment:
spring-xml uses JAXB as parser so I would assume the JAXB annotations
are required, not test scoped
##########
File path: core/camel-xml-io/pom.xml
##########
@@ -44,6 +44,11 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-xml-io-util</artifactId>
</dependency>
+ <dependency>
Review comment:
Do you know why camel-xml-io needs those JAXB annotations?
##########
File path: components/camel-spring-xml/pom.xml
##########
@@ -137,6 +137,11 @@
<artifactId>derby</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>javax.annotation</groupId>
+ <artifactId>javax.annotation-api</artifactId>
+ <scope>test</scope>
Review comment:
That is the same for camel-cdi as it also has a XML that is loaded via
JAXB.
And so does camel-blueprint in camel-karaf project
##########
File path: core/camel-api/pom.xml
##########
@@ -54,6 +54,12 @@
<artifactId>slf4j-api</artifactId>
</dependency>
+ <dependency>
Review comment:
Since JAXB annotations are only needed when using XML legacy parsing,
then I wonder if the scope should be optional.
Another goal for the future is to get rid of JAXB annotations all together
- but that is another battle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]