[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #3555: Improve available port discovery in tests

[GitBox]

jamesnetherton commented on a change in pull request #3555:
URL: https://github.com/apache/camel-quarkus/pull/3555#discussion_r807999526



##########
File path: 
integration-tests-support/test-support/src/main/java/org/apache/camel/quarkus/test/AvailablePortFinder.java
##########
@@ -103,4 +124,19 @@ private static boolean isQuarkusReservedPort(int port) {
         }
         return false;
     }
+
+    private static String getCallerClassName() {
+        return 
StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE)
+                .walk(s -> s.map(StackWalker.StackFrame::getClassName)
+                        .filter(className -> 
!className.equals(AvailablePortFinder.class.getName()))

Review comment:
       > Shouldn't we make AvailablePortFinder class final
   
   The class declaration is:
   
   ```java
   public final class AvailablePortFinder {
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org