This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push: new 213a696 (chores) components: removed unused code (#7016) 213a696 is described below commit 213a696b16c720e583d832a70fea78ddb08bb14e Author: Otavio Rodolfo Piske <orpi...@users.noreply.github.com> AuthorDate: Tue Feb 22 16:08:23 2022 +0100 (chores) components: removed unused code (#7016) --- .../component/activemq/converter/ConsumerBean.java | 12 ------------ .../camel/component/arangodb/ArangoDbProducer.java | 3 --- .../camel/component/as2/api/AS2ServerManager.java | 4 ---- .../component/as2/api/io/AS2SessionInputBuffer.java | 6 +++--- .../camel/component/as2/api/protocol/ResponseMDN.java | 5 ++--- .../org/apache/camel/component/as2/AS2Endpoint.java | 4 ++-- .../websocket/WebsocketRouteWithInitParamTest.java | 10 +++++----- .../atomix/client/AbstractAtomixClientProducer.java | 4 ---- .../aws2/ddb/localstack/AWS2DeleteItemRuleIT.java | 2 -- .../aws2/ddb/localstack/AWS2GetItemRuleIT.java | 2 -- .../aws2/ddb/localstack/AWS2PutItemRuleIT.java | 2 -- .../aws2/ddb/localstack/AWS2UpdateItemRuleIT.java | 2 -- .../camel/component/aws2/s3/AWS2S3Producer.java | 4 ++-- .../component/aws2/ses/SesComponentSpringTest.java | 4 ---- .../component/azure/storage/blob/BlobComponent.java | 5 ----- .../blob/operations/BlobOperationResponse.java | 4 ---- .../storage/blob/integration/BlobOperationsIT.java | 3 --- .../azure/storage/datalake/DataLakeComponent.java | 4 ---- .../azure/storage/datalake/DataLakeProducer.java | 9 ++------- .../datalake/client/DataLakeClientFactory.java | 4 ---- .../client/DataLakeFileSystemClientWrapper.java | 3 --- .../datalake/operations/DataLakeFileOperations.java | 3 --- .../datalake/component/DataLakeComponentTest.java | 4 ---- .../datalake/integration/DataLakeConsumerIT.java | 3 --- .../datalake/integration/DataLakeProducerIT.java | 4 ---- .../queue/operations/QueueOperationResponse.java | 8 -------- .../dataformat/barcode/BarcodeUnmarshalTest.java | 4 ---- .../org/apache/camel/component/bean/BeanInfo.java | 8 ++++---- .../org/apache/camel/component/bean/RegistryBean.java | 4 ++-- .../org/apache/camel/component/box/BoxEndpoint.java | 4 ++-- .../component/box/internal/BoxConnectionHelper.java | 4 ---- .../cassandra/CassandraAggregationRepository.java | 2 +- .../aggregate/cassandra/CassandraCamelCodec.java | 2 +- .../file/watch/FileWatchComponentTestBase.java | 6 ------ .../sftp/integration/SftpKeyPairRSAConsumeIT.java | 19 ------------------- .../camel/component/hdfs/HdfsNormalFileHandler.java | 8 ++++---- .../apache/camel/component/hdfs/HdfsTestSupport.java | 2 -- .../component/jms/JmsDefaultTaskExecutorTypeTest.java | 4 ++-- ...sTransactedOnExceptionRollbackOnExceptionTest.java | 2 ++ .../producer/support/KeyValueHolderIterator.java | 8 -------- .../apache/camel/component/metrics/TimerProducer.java | 4 ++-- .../camel/component/metrics/TimerProducerTest.java | 4 ++-- .../camel/component/rabbitmq/RabbitMQProducer.java | 6 +++--- .../component/rabbitmq/RabbitMQComponentTest.java | 1 - .../test/infra/services/RabbitMQServiceFactory.java | 4 ---- .../jdbc/ClusteredJdbcAggregationRepository.java | 2 +- .../aggregate/jdbc/JdbcAggregationRepository.java | 5 ++--- .../processor/aggregate/jdbc/JdbcCamelCodec.java | 6 +++--- .../AbstractClusteredJdbcAggregationTestSupport.java | 4 ---- .../service/TelegramServiceRestBotAPIAdapter.java | 1 - .../group/internal/ZooKeeperMultiGroup.java | 3 --- .../integration/ZooKeeperServiceCallRouteIT.java | 1 - .../zookeeper/integration/ZooKeeperITSupport.java | 2 +- .../operations/integration/CreateOperationIT.java | 2 +- 54 files changed, 49 insertions(+), 191 deletions(-) diff --git a/components/camel-activemq/src/test/java/org/apache/camel/component/activemq/converter/ConsumerBean.java b/components/camel-activemq/src/test/java/org/apache/camel/component/activemq/converter/ConsumerBean.java index 329178d..24df76e 100644 --- a/components/camel-activemq/src/test/java/org/apache/camel/component/activemq/converter/ConsumerBean.java +++ b/components/camel-activemq/src/test/java/org/apache/camel/component/activemq/converter/ConsumerBean.java @@ -94,22 +94,10 @@ public class ConsumerBean implements MessageListener { } } - public boolean isVerbose() { - return this.verbose; - } - - public void setVerbose(boolean verbose) { - this.verbose = verbose; - } - public List<Message> getMessages() { return this.messages; } - protected boolean hasReceivedMessage() { - return this.messages.isEmpty(); - } - protected boolean hasReceivedMessages(int messageCount) { synchronized (this.messages) { return this.messages.size() >= messageCount; diff --git a/components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbProducer.java b/components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbProducer.java index 8ddb5d2..c083d64 100644 --- a/components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbProducer.java +++ b/components/camel-arangodb/src/main/java/org/apache/camel/component/arangodb/ArangoDbProducer.java @@ -36,8 +36,6 @@ import org.apache.camel.Processor; import org.apache.camel.RuntimeCamelException; import org.apache.camel.support.DefaultProducer; import org.apache.camel.support.MessageHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.apache.camel.component.arangodb.ArangoDbConstants.AQL_QUERY; import static org.apache.camel.component.arangodb.ArangoDbConstants.AQL_QUERY_BIND_PARAMETERS; @@ -49,7 +47,6 @@ import static org.apache.camel.component.arangodb.ArangoDbConstants.MULTI_UPDATE import static org.apache.camel.component.arangodb.ArangoDbConstants.RESULT_CLASS_TYPE; public class ArangoDbProducer extends DefaultProducer { - private static final Logger LOG = LoggerFactory.getLogger(ArangoDbProducer.class); private final ArangoDbEndpoint endpoint; private final Map<ArangoDbOperation, Processor> operations = new HashMap<>(); diff --git a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ServerManager.java b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ServerManager.java index b79491a..7b79d5e 100644 --- a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ServerManager.java +++ b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ServerManager.java @@ -20,8 +20,6 @@ import org.apache.http.HttpEntityEnclosingRequest; import org.apache.http.HttpResponse; import org.apache.http.protocol.HttpContext; import org.apache.http.protocol.HttpRequestHandler; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * Receives EDI Messages over HTTP @@ -47,8 +45,6 @@ public class AS2ServerManager { */ public static final String FROM = CAMEL_AS2_SERVER_PREFIX + "from"; - private static final Logger LOG = LoggerFactory.getLogger(AS2ServerManager.class); - private AS2ServerConnection as2ServerConnection; public AS2ServerManager(AS2ServerConnection as2ServerConnection) { diff --git a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/io/AS2SessionInputBuffer.java b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/io/AS2SessionInputBuffer.java index d01968d..d4fad28 100644 --- a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/io/AS2SessionInputBuffer.java +++ b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/io/AS2SessionInputBuffer.java @@ -324,15 +324,15 @@ public class AS2SessionInputBuffer implements SessionInputBuffer, BufferInfo { int len = 0; while (bbuf.hasRemaining()) { final CoderResult result = this.decoder.decode(bbuf, this.cbuf, true); - len += handleDecodingResult(result, charbuffer, bbuf); + len += handleDecodingResult(result, charbuffer); } final CoderResult result = this.decoder.flush(this.cbuf); - len += handleDecodingResult(result, charbuffer, bbuf); + len += handleDecodingResult(result, charbuffer); cast(this.cbuf).clear(); return len; } - private int handleDecodingResult(final CoderResult result, final CharArrayBuffer charbuffer, final ByteBuffer bbuf) + private int handleDecodingResult(final CoderResult result, final CharArrayBuffer charbuffer) throws IOException { if (result.isError()) { result.throwException(); diff --git a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/protocol/ResponseMDN.java b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/protocol/ResponseMDN.java index bf546a8..ad8ec31 100644 --- a/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/protocol/ResponseMDN.java +++ b/components/camel-as2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/protocol/ResponseMDN.java @@ -141,7 +141,7 @@ public class ResponseMDN implements HttpResponseInterceptor { // Return a failed Message Disposition Notification Receipt in response body String mdnMessage = createMdnDescription(httpEntityEnclosingRequest, response, DispositionMode.AUTOMATIC_ACTION_MDN_SENT_AUTOMATICALLY, - AS2DispositionType.FAILED, null, null, null, null, null, AS2Charset.US_ASCII, mdnMessageTemplate); + AS2DispositionType.FAILED, null, null, null, null, null, mdnMessageTemplate); multipartReportEntity = new DispositionNotificationMultipartReportEntity( httpEntityEnclosingRequest, response, DispositionMode.AUTOMATIC_ACTION_MDN_SENT_AUTOMATICALLY, AS2DispositionType.FAILED, null, null, null, null, null, AS2Charset.US_ASCII, boundary, true, @@ -149,7 +149,7 @@ public class ResponseMDN implements HttpResponseInterceptor { } else { String mdnMessage = createMdnDescription(httpEntityEnclosingRequest, response, DispositionMode.AUTOMATIC_ACTION_MDN_SENT_AUTOMATICALLY, - AS2DispositionType.PROCESSED, null, null, null, null, null, AS2Charset.US_ASCII, + AS2DispositionType.PROCESSED, null, null, null, null, null, mdnMessageTemplate); multipartReportEntity = new DispositionNotificationMultipartReportEntity( httpEntityEnclosingRequest, response, DispositionMode.AUTOMATIC_ACTION_MDN_SENT_AUTOMATICALLY, @@ -255,7 +255,6 @@ public class ResponseMDN implements HttpResponseInterceptor { String[] errorFields, String[] warningFields, Map<String, String> extensionFields, - String charset, String mdnMessageTemplate) throws HttpException { diff --git a/components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Endpoint.java b/components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Endpoint.java index 2f3b6dc..09e0d30 100644 --- a/components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Endpoint.java +++ b/components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Endpoint.java @@ -252,12 +252,12 @@ public class AS2Endpoint extends AbstractApiEndpoint<AS2ApiName, AS2Configuratio @Override public Object getApiProxy(ApiMethod method, Map<String, Object> args) { if (apiProxy == null) { - createApiProxy(method, args); + createApiProxy(); } return apiProxy; } - private void createApiProxy(ApiMethod method, Map<String, Object> args) { + private void createApiProxy() { switch (apiName) { case CLIENT: apiProxy = new AS2ClientManager(getAS2ClientConnection()); diff --git a/components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java b/components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java index dae20e9..542ae804 100644 --- a/components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java +++ b/components/camel-atmosphere-websocket/src/test/java/org/apache/camel/component/atmosphere/websocket/WebsocketRouteWithInitParamTest.java @@ -180,13 +180,13 @@ public class WebsocketRouteWithInitParamTest extends WebsocketCamelRouterWithIni .when(header(WebsocketConstants.EVENT_TYPE).isEqualTo(WebsocketConstants.ONCLOSE_EVENT_TYPE)) .process(new Processor() { public void process(final Exchange exchange) { - removeExternalConnectionRegister(exchange); + removeExternalConnectionRegister(); } }) .when(header(WebsocketConstants.EVENT_TYPE).isEqualTo(WebsocketConstants.ONERROR_EVENT_TYPE)) .process(new Processor() { public void process(final Exchange exchange) { - removeExternalConnectionRegister(exchange); + removeExternalConnectionRegister(); } }) .otherwise() @@ -208,13 +208,13 @@ public class WebsocketRouteWithInitParamTest extends WebsocketCamelRouterWithIni .when(header(WebsocketConstants.EVENT_TYPE).isEqualTo(WebsocketConstants.ONCLOSE_EVENT_TYPE)) .process(new Processor() { public void process(final Exchange exchange) { - removeExternalConnectionRegister(exchange); + removeExternalConnectionRegister(); } }) .when(header(WebsocketConstants.EVENT_TYPE).isEqualTo(WebsocketConstants.ONERROR_EVENT_TYPE)) .process(new Processor() { public void process(final Exchange exchange) { - removeExternalConnectionRegister(exchange); + removeExternalConnectionRegister(); } }) .when(header(WebsocketConstants.ERROR_TYPE).isEqualTo(WebsocketConstants.MESSAGE_NOT_SENT_ERROR_TYPE)) @@ -251,7 +251,7 @@ public class WebsocketRouteWithInitParamTest extends WebsocketCamelRouterWithIni connectionKeyUserMap.put(userName, (String) connectionKey); } - private static void removeExternalConnectionRegister(Exchange exchange) { + private static void removeExternalConnectionRegister() { // remove connectionKey from external store } diff --git a/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/AbstractAtomixClientProducer.java b/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/AbstractAtomixClientProducer.java index f39d217..120dd84 100644 --- a/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/AbstractAtomixClientProducer.java +++ b/components/camel-atomix/src/main/java/org/apache/camel/component/atomix/client/AbstractAtomixClientProducer.java @@ -24,16 +24,12 @@ import org.apache.camel.AsyncCallback; import org.apache.camel.Message; import org.apache.camel.support.HeaderSelectorProducer; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.apache.camel.component.atomix.client.AtomixClientConstants.*; public abstract class AbstractAtomixClientProducer<E extends AbstractAtomixClientEndpoint, R extends Resource> extends HeaderSelectorProducer { - private static final Logger LOG = LoggerFactory.getLogger(AbstractAtomixClientProducer.class); - private ConcurrentMap<String, R> resources; protected AbstractAtomixClientProducer(E endpoint, String defaultHeader) { diff --git a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2DeleteItemRuleIT.java b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2DeleteItemRuleIT.java index db3fb8e..9944b6f 100644 --- a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2DeleteItemRuleIT.java +++ b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2DeleteItemRuleIT.java @@ -43,8 +43,6 @@ public class AWS2DeleteItemRuleIT extends Aws2DDBBase { private final String attributeName = "clave"; private final String tableName = "TestTable"; - private final String randomId = String.valueOf(System.currentTimeMillis()); - @Test public void putItem() { final Map<String, AttributeValue> attributeMap = new HashMap<>(); diff --git a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2GetItemRuleIT.java b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2GetItemRuleIT.java index 07d19ca..d25a06d 100644 --- a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2GetItemRuleIT.java +++ b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2GetItemRuleIT.java @@ -42,8 +42,6 @@ public class AWS2GetItemRuleIT extends Aws2DDBBase { private final String attributeName = "clave"; private final String tableName = "TestTable"; - private final String randomId = String.valueOf(System.currentTimeMillis()); - @Test public void putItem() { final Map<String, AttributeValue> attributeMap = new HashMap<>(); diff --git a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2PutItemRuleIT.java b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2PutItemRuleIT.java index 3b29232..b3b8c26 100644 --- a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2PutItemRuleIT.java +++ b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2PutItemRuleIT.java @@ -41,8 +41,6 @@ public class AWS2PutItemRuleIT extends Aws2DDBBase { private final String attributeName = "clave"; private final String tableName = "TestTable"; - private final String randomId = String.valueOf(System.currentTimeMillis()); - @Test public void putItem() { final Map<String, AttributeValue> attributeMap = new HashMap<>(); diff --git a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2UpdateItemRuleIT.java b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2UpdateItemRuleIT.java index 78d00a6..fad8f77 100644 --- a/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2UpdateItemRuleIT.java +++ b/components/camel-aws/camel-aws2-ddb/src/test/java/org/apache/camel/component/aws2/ddb/localstack/AWS2UpdateItemRuleIT.java @@ -46,8 +46,6 @@ public class AWS2UpdateItemRuleIT extends Aws2DDBBase { private final String attributeName = "clave"; private final String tableName = "TestTable"; - private final String randomId = String.valueOf(System.currentTimeMillis()); - @Test public void putItem() { final Map<String, AttributeValue> attributeMap = new HashMap<>(); diff --git a/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java b/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java index 658398d..f46f96e 100644 --- a/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java +++ b/components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java @@ -118,7 +118,7 @@ public class AWS2S3Producer extends DefaultProducer { getObjectRange(getEndpoint().getS3Client(), exchange); break; case createDownloadLink: - createDownloadLink(getEndpoint().getS3Client(), exchange); + createDownloadLink(exchange); break; default: throw new IllegalArgumentException("Unsupported operation"); @@ -544,7 +544,7 @@ public class AWS2S3Producer extends DefaultProducer { } } - private void createDownloadLink(S3Client s3Client, Exchange exchange) { + private void createDownloadLink(Exchange exchange) { final String bucketName = AWS2S3Utils.determineBucketName(exchange, getConfiguration()); final String key = AWS2S3Utils.determineKey(exchange, getConfiguration()); diff --git a/components/camel-aws/camel-aws2-ses/src/test/java/org/apache/camel/component/aws2/ses/SesComponentSpringTest.java b/components/camel-aws/camel-aws2-ses/src/test/java/org/apache/camel/component/aws2/ses/SesComponentSpringTest.java index a46af63..a7549e6 100644 --- a/components/camel-aws/camel-aws2-ses/src/test/java/org/apache/camel/component/aws2/ses/SesComponentSpringTest.java +++ b/components/camel-aws/camel-aws2-ses/src/test/java/org/apache/camel/component/aws2/ses/SesComponentSpringTest.java @@ -133,8 +133,4 @@ public class SesComponentSpringTest extends CamelSpringTestSupport { private List<String> getTo(SendEmailRequest sendEmailRequest) { return sendEmailRequest.destination().toAddresses(); } - - private List<String> getTo(SendRawEmailRequest sendEmailRequest) { - return sendEmailRequest.destinations(); - } } diff --git a/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/BlobComponent.java b/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/BlobComponent.java index 0dd9d7e..0d850d8 100644 --- a/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/BlobComponent.java +++ b/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/BlobComponent.java @@ -26,17 +26,12 @@ import org.apache.camel.Endpoint; import org.apache.camel.spi.Metadata; import org.apache.camel.spi.annotations.Component; import org.apache.camel.support.DefaultComponent; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * Azure Blob Storage component using azure java sdk v12.x */ @Component("azure-storage-blob") public class BlobComponent extends DefaultComponent { - - private static final Logger LOG = LoggerFactory.getLogger(BlobComponent.class); - @Metadata private BlobConfiguration configuration = new BlobConfiguration(); diff --git a/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/operations/BlobOperationResponse.java b/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/operations/BlobOperationResponse.java index bca02c9..74d85d3 100644 --- a/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/operations/BlobOperationResponse.java +++ b/components/camel-azure/camel-azure-storage-blob/src/main/java/org/apache/camel/component/azure/storage/blob/operations/BlobOperationResponse.java @@ -100,8 +100,4 @@ public final class BlobOperationResponse { public Map<String, Object> getHeaders() { return headers; } - - private void setHeaders(final Map<String, Object> headers) { - this.headers = headers; - } } diff --git a/components/camel-azure/camel-azure-storage-blob/src/test/java/org/apache/camel/component/azure/storage/blob/integration/BlobOperationsIT.java b/components/camel-azure/camel-azure-storage-blob/src/test/java/org/apache/camel/component/azure/storage/blob/integration/BlobOperationsIT.java index ccc1560..cbf24f0 100644 --- a/components/camel-azure/camel-azure-storage-blob/src/test/java/org/apache/camel/component/azure/storage/blob/integration/BlobOperationsIT.java +++ b/components/camel-azure/camel-azure-storage-blob/src/test/java/org/apache/camel/component/azure/storage/blob/integration/BlobOperationsIT.java @@ -331,7 +331,6 @@ class BlobOperationsIT extends Base { byte[] dataBytes = new byte[1024]; // we set range for the page from 0-511 new SecureRandom().nextBytes(dataBytes); - final String data = new String(dataBytes, StandardCharsets.UTF_8); final InputStream dataStream = new ByteArrayInputStream(dataBytes); final PageRange pageRange = new PageRange().setStart(0).setEnd(1023); @@ -367,7 +366,6 @@ class BlobOperationsIT extends Base { byte[] dataBytes = new byte[512]; // we set range for the page from 0-511 new SecureRandom().nextBytes(dataBytes); - final String data = new String(dataBytes, StandardCharsets.UTF_8); final InputStream dataStream = new ByteArrayInputStream(dataBytes); final PageRange pageRange = new PageRange().setStart(0).setEnd(511); @@ -396,7 +394,6 @@ class BlobOperationsIT extends Base { byte[] dataBytes = new byte[512]; // we set range for the page from 0-511 new SecureRandom().nextBytes(dataBytes); - final String data = new String(dataBytes, StandardCharsets.UTF_8); final InputStream dataStream = new ByteArrayInputStream(dataBytes); final PageRange pageRange = new PageRange().setStart(0).setEnd(511); diff --git a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeComponent.java b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeComponent.java index 737619e..962ebb9 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeComponent.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeComponent.java @@ -27,14 +27,10 @@ import org.apache.camel.spi.Metadata; import org.apache.camel.spi.annotations.Component; import org.apache.camel.support.DefaultComponent; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; @Component("azure-storage-datalake") public class DataLakeComponent extends DefaultComponent { - private static final Logger LOG = LoggerFactory.getLogger(DataLakeComponent.class); - @Metadata(description = "configuration object for datalake") private DataLakeConfiguration configuration = new DataLakeConfiguration(); diff --git a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeProducer.java b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeProducer.java index 6a2d060..8860252 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeProducer.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/DataLakeProducer.java @@ -31,19 +31,14 @@ import org.apache.camel.component.azure.storage.datalake.operations.DataLakeOper import org.apache.camel.component.azure.storage.datalake.operations.DataLakeServiceOperations; import org.apache.camel.support.DefaultProducer; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public class DataLakeProducer extends DefaultProducer { - - private static final Logger LOG = LoggerFactory.getLogger(DataLakeProducer.class); private final DataLakeConfiguration configuration; private final DataLakeConfigurationOptionsProxy configurationProxy; private final DataLakeServiceClientWrapper dataLakeServiceClientWrapper; public DataLakeProducer(final Endpoint endpoint) { super(endpoint); - // this.configuration = getEndpoint().getConfiguration(); configuration = getEndpoint().getConfiguration(); configurationProxy = new DataLakeConfigurationOptionsProxy(configuration); dataLakeServiceClientWrapper = new DataLakeServiceClientWrapper(getEndpoint().getDataLakeServiceClient()); @@ -59,7 +54,7 @@ public class DataLakeProducer extends DefaultProducer { DataLakeOperationsDefinition operation = determineOperation(exchange); switch (operation) { case listFileSystem: - setResponse(exchange, getServiceOperations(exchange).listFileSystems(exchange)); + setResponse(exchange, getServiceOperations().listFileSystems(exchange)); break; case createFileSystem: setResponse(exchange, getFileSystemOperations(exchange).createFileSystem(exchange)); @@ -117,7 +112,7 @@ public class DataLakeProducer extends DefaultProducer { return configurationProxy.getOperation(exchange); } - private DataLakeServiceOperations getServiceOperations(final Exchange exchange) { + private DataLakeServiceOperations getServiceOperations() { return new DataLakeServiceOperations(configuration, dataLakeServiceClientWrapper); } diff --git a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeClientFactory.java b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeClientFactory.java index 4240d2b..ab6da91 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeClientFactory.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeClientFactory.java @@ -25,12 +25,8 @@ import com.azure.storage.file.datalake.DataLakeServiceClient; import com.azure.storage.file.datalake.DataLakeServiceClientBuilder; import org.apache.camel.component.azure.storage.datalake.DataLakeConfiguration; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public final class DataLakeClientFactory { - - private static final Logger LOG = LoggerFactory.getLogger(DataLakeClientFactory.class); private static final String SERVICE_URI_SEGMENT = ".dfs.core.windows.net"; private DataLakeClientFactory() { diff --git a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeFileSystemClientWrapper.java b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeFileSystemClientWrapper.java index f4fd99a..0eaa530 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeFileSystemClientWrapper.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/client/DataLakeFileSystemClientWrapper.java @@ -29,12 +29,9 @@ import com.azure.storage.file.datalake.models.ListPathsOptions; import com.azure.storage.file.datalake.models.PathItem; import com.azure.storage.file.datalake.models.PublicAccessType; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public class DataLakeFileSystemClientWrapper { - private static final Logger LOG = LoggerFactory.getLogger(DataLakeFileSystemClientWrapper.class); private final DataLakeFileSystemClient client; public DataLakeFileSystemClientWrapper(final DataLakeFileSystemClient client) { diff --git a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/operations/DataLakeFileOperations.java b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/operations/DataLakeFileOperations.java index dce074c..9c3550d 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/operations/DataLakeFileOperations.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/main/java/org/apache/camel/component/azure/storage/datalake/operations/DataLakeFileOperations.java @@ -50,11 +50,8 @@ import org.apache.camel.component.azure.storage.datalake.FileCommonRequestOption import org.apache.camel.component.azure.storage.datalake.FileStreamAndLength; import org.apache.camel.component.azure.storage.datalake.client.DataLakeFileClientWrapper; import org.apache.camel.util.ObjectHelper; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public class DataLakeFileOperations { - private static final Logger LOG = LoggerFactory.getLogger(DataLakeFileOperations.class); private final DataLakeFileClientWrapper client; private final DataLakeConfigurationOptionsProxy configurationProxy; diff --git a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/component/DataLakeComponentTest.java b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/component/DataLakeComponentTest.java index ba19b74..2cd3268 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/component/DataLakeComponentTest.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/component/DataLakeComponentTest.java @@ -26,8 +26,6 @@ import org.apache.camel.component.azure.storage.datalake.client.DataLakeClientFa import org.apache.camel.support.DefaultExchange; import org.apache.camel.test.junit5.CamelTestSupport; import org.junit.jupiter.api.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; @@ -36,8 +34,6 @@ import static org.junit.jupiter.api.Assertions.assertThrows; class DataLakeComponentTest extends CamelTestSupport { - private static final Logger LOG = LoggerFactory.getLogger(DataLakeComponentTest.class); - @Test public void testWithServiceClient() { final DataLakeConfiguration configuration = new DataLakeConfiguration(); diff --git a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeConsumerIT.java b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeConsumerIT.java index 6a6687e..bc49d04 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeConsumerIT.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeConsumerIT.java @@ -44,8 +44,6 @@ import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; import org.junit.jupiter.api.io.TempDir; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; @@ -56,7 +54,6 @@ public class DataLakeConsumerIT extends Base { @TempDir static Path testDir; - private static final Logger LOG = LoggerFactory.getLogger(DataLakeConsumerIT.class); @EndpointInject("direct:createFile") private ProducerTemplate templateStart; diff --git a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeProducerIT.java b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeProducerIT.java index 026cb70..ff193de 100644 --- a/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeProducerIT.java +++ b/components/camel-azure/camel-azure-storage-datalake/src/test/java/org/apache/camel/component/azure/storage/datalake/integration/DataLakeProducerIT.java @@ -29,16 +29,12 @@ import org.assertj.core.api.Assertions; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIfSystemProperty; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.junit.jupiter.api.Assertions.assertEquals; @EnabledIfSystemProperty(named = "azure.instance.type", matches = "remote") public class DataLakeProducerIT extends Base { - private static final Logger LOG = LoggerFactory.getLogger(DataLakeProducerIT.class); - private String fileName; private byte[] fileContent; diff --git a/components/camel-azure/camel-azure-storage-queue/src/main/java/org/apache/camel/component/azure/storage/queue/operations/QueueOperationResponse.java b/components/camel-azure/camel-azure-storage-queue/src/main/java/org/apache/camel/component/azure/storage/queue/operations/QueueOperationResponse.java index fe6ad14..16d8a52 100644 --- a/components/camel-azure/camel-azure-storage-queue/src/main/java/org/apache/camel/component/azure/storage/queue/operations/QueueOperationResponse.java +++ b/components/camel-azure/camel-azure-storage-queue/src/main/java/org/apache/camel/component/azure/storage/queue/operations/QueueOperationResponse.java @@ -54,10 +54,6 @@ public final class QueueOperationResponse { return new QueueOperationResponse(true, headers); } - public static QueueOperationResponse createWithEmptyBody() { - return new QueueOperationResponse(true); - } - @SuppressWarnings("rawtypes") public static QueueOperationResponse createWithEmptyBody(final Response response) { return buildResponse(response, true); @@ -91,8 +87,4 @@ public final class QueueOperationResponse { public Map<String, Object> getHeaders() { return headers; } - - private void setHeaders(final Map<String, Object> headers) { - this.headers = headers; - } } diff --git a/components/camel-barcode/src/test/java/org/apache/camel/dataformat/barcode/BarcodeUnmarshalTest.java b/components/camel-barcode/src/test/java/org/apache/camel/dataformat/barcode/BarcodeUnmarshalTest.java index 5bcea9c..8eedafb 100644 --- a/components/camel-barcode/src/test/java/org/apache/camel/dataformat/barcode/BarcodeUnmarshalTest.java +++ b/components/camel-barcode/src/test/java/org/apache/camel/dataformat/barcode/BarcodeUnmarshalTest.java @@ -31,15 +31,11 @@ import org.apache.camel.Processor; import org.apache.camel.builder.RouteBuilder; import org.apache.camel.spi.DataFormat; import org.junit.jupiter.api.Test; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import static org.junit.jupiter.api.Assertions.assertEquals; public class BarcodeUnmarshalTest extends BarcodeTestBase { - private static final Logger LOG = LoggerFactory.getLogger(BarcodeUnmarshalTest.class); - @Test void testOrientation() throws Exception { diff --git a/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java b/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java index 07a1efa..72a5b8b 100644 --- a/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java +++ b/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java @@ -427,7 +427,7 @@ public class BeanInfo { Class<?> parameterType = parameterTypes[i]; Annotation[] parameterAnnotations = parametersAnnotations[i].toArray(new Annotation[parametersAnnotations[i].size()]); - Expression expression = createParameterUnmarshalExpression(clazz, method, parameterType, parameterAnnotations); + Expression expression = createParameterUnmarshalExpression(method, parameterType, parameterAnnotations); hasCustomAnnotation |= expression != null; ParameterInfo parameterInfo = new ParameterInfo(i, parameterType, parameterAnnotations, expression); @@ -969,12 +969,12 @@ public class BeanInfo { * parameter cannot be mapped due to insufficient annotations or not fitting with the default type conventions. */ private Expression createParameterUnmarshalExpression( - Class<?> clazz, Method method, + Method method, Class<?> parameterType, Annotation[] parameterAnnotation) { // look for a parameter annotation that converts into an expression for (Annotation annotation : parameterAnnotation) { - Expression answer = createParameterUnmarshalExpressionForAnnotation(clazz, method, parameterType, annotation); + Expression answer = createParameterUnmarshalExpressionForAnnotation(method, parameterType, annotation); if (answer != null) { return answer; } @@ -984,7 +984,7 @@ public class BeanInfo { } private Expression createParameterUnmarshalExpressionForAnnotation( - Class<?> clazz, Method method, + Method method, Class<?> parameterType, Annotation annotation) { if (annotation instanceof ExchangeProperty) { ExchangeProperty propertyAnnotation = (ExchangeProperty) annotation; diff --git a/components/camel-bean/src/main/java/org/apache/camel/component/bean/RegistryBean.java b/components/camel-bean/src/main/java/org/apache/camel/component/bean/RegistryBean.java index c41e717..c4db685 100644 --- a/components/camel-bean/src/main/java/org/apache/camel/component/bean/RegistryBean.java +++ b/components/camel-bean/src/main/java/org/apache/camel/component/bean/RegistryBean.java @@ -99,7 +99,7 @@ public class RegistryBean implements BeanHolder { @Override public Object getBean(Exchange exchange) throws NoSuchBeanException { - Object bean = doGetBean(exchange); + Object bean = doGetBean(); if (options != null && !options.isEmpty()) { PropertyBindingSupport.build() .withRemoveParameters(false) @@ -111,7 +111,7 @@ public class RegistryBean implements BeanHolder { return bean; } - private Object doGetBean(Exchange exchange) throws NoSuchBeanException { + private Object doGetBean() throws NoSuchBeanException { // must always lookup bean first Object value = lookupBean(); diff --git a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/BoxEndpoint.java b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/BoxEndpoint.java index 1d88221..c533c6c 100644 --- a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/BoxEndpoint.java +++ b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/BoxEndpoint.java @@ -116,7 +116,7 @@ public class BoxEndpoint extends AbstractApiEndpoint<BoxApiName, BoxConfiguratio public Object getApiProxy(ApiMethod method, Map<String, Object> args) { if (apiProxy == null) { // create API proxy lazily - createApiProxy(args); + createApiProxy(); } return apiProxy; } @@ -138,7 +138,7 @@ public class BoxEndpoint extends AbstractApiEndpoint<BoxApiName, BoxConfiguratio } } - private void createApiProxy(Map<String, Object> args) { + private void createApiProxy() { switch (apiName) { case COLLABORATIONS: apiProxy = new BoxCollaborationsManager(getBoxConnection()); diff --git a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java index 9e846e4..be976b1 100644 --- a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java +++ b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java @@ -43,8 +43,6 @@ import org.jsoup.nodes.Document; import org.jsoup.nodes.Element; import org.jsoup.nodes.FormElement; import org.jsoup.select.Elements; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * BoxConnectionHelper @@ -54,8 +52,6 @@ import org.slf4j.LoggerFactory; */ public final class BoxConnectionHelper { - private static final Logger LOG = LoggerFactory.getLogger(BoxConnectionHelper.class); - private static final Pattern QUERY_PARAM_PATTERN = Pattern.compile("&?([^=]+)=([^&]+)"); private BoxConnectionHelper() { diff --git a/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraAggregationRepository.java b/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraAggregationRepository.java index bb6696a..00277bb 100644 --- a/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraAggregationRepository.java +++ b/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraAggregationRepository.java @@ -181,7 +181,7 @@ public class CassandraAggregationRepository extends ServiceSupport implements Re final Object[] idValues = getPKValues(key); LOGGER.debug("Inserting key {} exchange {}", idValues, exchange); try { - ByteBuffer marshalledExchange = exchangeCodec.marshallExchange(camelContext, exchange, allowSerializedHeaders); + ByteBuffer marshalledExchange = exchangeCodec.marshallExchange(exchange, allowSerializedHeaders); Object[] cqlParams = concat(idValues, new Object[] { exchange.getExchangeId(), marshalledExchange }); getSession().execute(insertStatement.bind(cqlParams)); return exchange; diff --git a/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraCamelCodec.java b/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraCamelCodec.java index 464a2de..476ec0d 100644 --- a/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraCamelCodec.java +++ b/components/camel-cassandraql/src/main/java/org/apache/camel/processor/aggregate/cassandra/CassandraCamelCodec.java @@ -36,7 +36,7 @@ import org.apache.camel.support.DefaultExchangeHolder; */ public class CassandraCamelCodec { - public ByteBuffer marshallExchange(CamelContext camelContext, Exchange exchange, boolean allowSerializedHeaders) + public ByteBuffer marshallExchange(Exchange exchange, boolean allowSerializedHeaders) throws IOException { // use DefaultExchangeHolder to marshal to a serialized object DefaultExchangeHolder pe = DefaultExchangeHolder.marshal(exchange, false, allowSerializedHeaders); diff --git a/components/camel-file-watch/src/test/java/org/apache/camel/component/file/watch/FileWatchComponentTestBase.java b/components/camel-file-watch/src/test/java/org/apache/camel/component/file/watch/FileWatchComponentTestBase.java index cba42cb..ac9fd29 100644 --- a/components/camel-file-watch/src/test/java/org/apache/camel/component/file/watch/FileWatchComponentTestBase.java +++ b/components/camel-file-watch/src/test/java/org/apache/camel/component/file/watch/FileWatchComponentTestBase.java @@ -50,12 +50,6 @@ public class FileWatchComponentTestBase extends CamelTestSupport { assertEquals(expectedEventType, exchange.getIn().getHeader(FileWatchComponent.EVENT_TYPE_HEADER, FileEventEnum.class)); } - static boolean isWindows() { - //WatchService behaves differently on Windows (Emits both MODIFY and DELETE when file deleted) - //see https://stackoverflow.com/questions/33753561/java-nio-watch-service-created-both-entry-create-and-entry-modify-when-a-new - return System.getProperty("os.name").toLowerCase().contains("win"); - } - public void beforeEach(ExtensionContext context) throws Exception { super.beforeEach(context); this.testMethod = context.getTestMethod().map(Method::getName).orElse(""); diff --git a/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpKeyPairRSAConsumeIT.java b/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpKeyPairRSAConsumeIT.java index 0a6647c..63079d5 100644 --- a/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpKeyPairRSAConsumeIT.java +++ b/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpKeyPairRSAConsumeIT.java @@ -16,19 +16,12 @@ */ package org.apache.camel.component.file.remote.sftp.integration; -import java.io.ByteArrayOutputStream; -import java.io.File; -import java.io.FileInputStream; -import java.io.IOException; -import java.io.InputStream; import java.security.KeyPair; import java.security.KeyPairGenerator; import org.apache.camel.Exchange; import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.mock.MockEndpoint; -import org.apache.camel.util.IOHelper; -import org.apache.sshd.server.auth.pubkey.PublickeyAuthenticator; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.condition.EnabledIf; @@ -62,18 +55,6 @@ public class SftpKeyPairRSAConsumeIT extends SftpServerTestSupport { assertMockEndpointsSatisfied(); } - private byte[] getBytesFromFile(String filename) throws IOException { - InputStream input; - input = new FileInputStream(new File(filename)); - ByteArrayOutputStream output = new ByteArrayOutputStream(); - IOHelper.copyAndCloseInput(input, output); - return output.toByteArray(); - } - - protected PublickeyAuthenticator getPublickeyAuthenticator() { - return (username, key, session) -> key.equals(keyPair.getPublic()); - } - @Override protected RouteBuilder createRouteBuilder() throws Exception { context.getRegistry().bind("keyPair", keyPair); diff --git a/components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java b/components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java index 372cb06..f091eef6 100644 --- a/components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java +++ b/components/camel-hdfs/src/main/java/org/apache/camel/component/hdfs/HdfsNormalFileHandler.java @@ -102,13 +102,13 @@ class HdfsNormalFileHandler extends DefaultHdfsFile<OutputStream, InputStream> { @Override public long next(HdfsInputStream hdfsInputStream, Holder<Object> key, Holder<Object> value) { if (hdfsInputStream.isStreamDownload()) { - return nextAsWrappedStream(hdfsInputStream, key, value); + return nextAsWrappedStream(hdfsInputStream, value); } else { - return nextAsOutputStream(hdfsInputStream, key, value); + return nextAsOutputStream(hdfsInputStream, value); } } - private long nextAsWrappedStream(HdfsInputStream hdfsInputStream, Holder<Object> key, Holder<Object> value) { + private long nextAsWrappedStream(HdfsInputStream hdfsInputStream, Holder<Object> value) { InputStream inputStream = (InputStream) hdfsInputStream.getIn(); value.setValue(inputStream); @@ -120,7 +120,7 @@ class HdfsNormalFileHandler extends DefaultHdfsFile<OutputStream, InputStream> { } } - private long nextAsOutputStream(HdfsInputStream hdfsInputStream, Holder<Object> key, Holder<Object> value) { + private long nextAsOutputStream(HdfsInputStream hdfsInputStream, Holder<Object> value) { try { ByteArrayOutputStream outputStream = new ByteArrayOutputStream(hdfsInputStream.getChunkSize()); byte[] buf = new byte[hdfsInputStream.getChunkSize()]; diff --git a/components/camel-hdfs/src/test/java/org/apache/camel/component/hdfs/HdfsTestSupport.java b/components/camel-hdfs/src/test/java/org/apache/camel/component/hdfs/HdfsTestSupport.java index 2ed4978..dc54d1a 100644 --- a/components/camel-hdfs/src/test/java/org/apache/camel/component/hdfs/HdfsTestSupport.java +++ b/components/camel-hdfs/src/test/java/org/apache/camel/component/hdfs/HdfsTestSupport.java @@ -29,8 +29,6 @@ public abstract class HdfsTestSupport extends CamelTestSupport { public static final File CWD = new File("."); - private static Boolean skipTests; - public void checkTest() { isJavaFromIbm(); missingLocalHadoopConfiguration(); diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java index e1a9758..5a4b5e6 100644 --- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java +++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java @@ -127,7 +127,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport { } private void doSendMessages( - final String queueName, int messages, int poolSize, + final String queueName, int messages, final DefaultTaskExecutorType defaultTaskExecutorType, CountDownLatch latch, ExecutorService executor) { for (int i = 0; i < messages; i++) { @@ -151,7 +151,7 @@ public class JmsDefaultTaskExecutorTypeTest extends CamelTestSupport { final CountDownLatch latch = new CountDownLatch(messages); try { - doSendMessages(queueName, messages, poolSize, defaultTaskExecutorType, latch, executor); + doSendMessages(queueName, messages, defaultTaskExecutorType, latch, executor); executor.shutdown(); executor.awaitTermination(5, TimeUnit.SECONDS); } finally { diff --git a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsTransactedOnExceptionRollbackOnExceptionTest.java b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsTransactedOnExceptionRollbackOnExceptionTest.java index cb0adab..591f345 100644 --- a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsTransactedOnExceptionRollbackOnExceptionTest.java +++ b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsTransactedOnExceptionRollbackOnExceptionTest.java @@ -34,6 +34,8 @@ import static org.junit.jupiter.api.Assertions.assertEquals; public class JmsTransactedOnExceptionRollbackOnExceptionTest extends CamelTestSupport { public static class BadErrorHandler { + + @SuppressWarnings("unused") @Handler public void onException(Exchange exchange, Exception exception) throws Exception { throw new RuntimeCamelException("error in errorhandler"); diff --git a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/producer/support/KeyValueHolderIterator.java b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/producer/support/KeyValueHolderIterator.java index 8e37321..a207a97 100644 --- a/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/producer/support/KeyValueHolderIterator.java +++ b/components/camel-kafka/src/main/java/org/apache/camel/component/kafka/producer/support/KeyValueHolderIterator.java @@ -98,14 +98,6 @@ public class KeyValueHolderIterator implements Iterator<KeyValueHolder<Object, P return null; } - private boolean hasValidTimestampHeader(Object timeStamp) { - if (timeStamp != null) { - return timeStamp instanceof Long; - } - - return false; - } - private Long getOverrideTimestamp(Message innerMessage) { Long timeStamp = null; Object overrideTimeStamp = innerMessage.removeHeader(KafkaConstants.OVERRIDE_TIMESTAMP); diff --git a/components/camel-metrics/src/main/java/org/apache/camel/component/metrics/TimerProducer.java b/components/camel-metrics/src/main/java/org/apache/camel/component/metrics/TimerProducer.java index 4480bbc..c35849c 100644 --- a/components/camel-metrics/src/main/java/org/apache/camel/component/metrics/TimerProducer.java +++ b/components/camel-metrics/src/main/java/org/apache/camel/component/metrics/TimerProducer.java @@ -42,7 +42,7 @@ public class TimerProducer extends AbstractMetricsProducer { if (finalAction == MetricsTimerAction.start) { handleStart(exchange, registry, metricsName); } else if (finalAction == MetricsTimerAction.stop) { - handleStop(exchange, registry, metricsName); + handleStop(exchange, metricsName); } else { LOG.warn("No action provided for timer \"{}\"", metricsName); } @@ -60,7 +60,7 @@ public class TimerProducer extends AbstractMetricsProducer { } } - void handleStop(Exchange exchange, MetricRegistry registry, String metricsName) { + void handleStop(Exchange exchange, String metricsName) { String propertyName = getPropertyName(metricsName); Timer.Context context = getTimerContextFromExchange(exchange, propertyName); if (context != null) { diff --git a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java index 020d474..cda1cf0 100644 --- a/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java +++ b/components/camel-metrics/src/test/java/org/apache/camel/component/metrics/TimerProducerTest.java @@ -195,7 +195,7 @@ public class TimerProducerTest { @Test public void testHandleStop() throws Exception { when(exchange.getProperty(PROPERTY_NAME, Timer.Context.class)).thenReturn(context); - producer.handleStop(exchange, registry, METRICS_NAME); + producer.handleStop(exchange, METRICS_NAME); inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME, Timer.Context.class); inOrder.verify(context, times(1)).stop(); inOrder.verify(exchange, times(1)).removeProperty(PROPERTY_NAME); @@ -205,7 +205,7 @@ public class TimerProducerTest { @Test public void testHandleStopContextNotFound() throws Exception { when(exchange.getProperty(PROPERTY_NAME, Timer.Context.class)).thenReturn(null); - producer.handleStop(exchange, registry, METRICS_NAME); + producer.handleStop(exchange, METRICS_NAME); inOrder.verify(exchange, times(1)).getProperty(PROPERTY_NAME, Timer.Context.class); inOrder.verifyNoMoreInteractions(); } diff --git a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java index 8692ded..af83ca1 100644 --- a/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java +++ b/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQProducer.java @@ -263,7 +263,7 @@ public class RabbitMQProducer extends DefaultAsyncProducer { replyManager.registerReply(replyManager, exchange, callback, originalCorrelationId, correlationId, timeout); try { - basicPublish(exchange, exchangeName, key); + basicPublish(exchange, key); } catch (Exception e) { replyManager.cancelCorrelationId(correlationId); exchange.setException(e); @@ -295,7 +295,7 @@ public class RabbitMQProducer extends DefaultAsyncProducer { throw new IllegalArgumentException("ExchangeName and RoutingKey is not provided in the endpoint: " + getEndpoint()); } - basicPublish(exchange, exchangeName, key); + basicPublish(exchange, key); callback.done(true); return true; } @@ -303,7 +303,7 @@ public class RabbitMQProducer extends DefaultAsyncProducer { /** * Send a message borrowing a channel from the pool. */ - private void basicPublish(final Exchange camelExchange, final String rabbitExchange, final String routingKey) + private void basicPublish(final Exchange camelExchange, final String routingKey) throws Exception { if (channelPool == null) { // Open connection and channel lazily if another thread hasn't diff --git a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/RabbitMQComponentTest.java b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/RabbitMQComponentTest.java index 1d69a7e..b5be08d 100644 --- a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/RabbitMQComponentTest.java +++ b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/RabbitMQComponentTest.java @@ -99,7 +99,6 @@ public class RabbitMQComponentTest extends CamelTestSupport { private RabbitMQEndpoint createEndpoint(Map<String, Object> params) throws Exception { String uri = "rabbitmq:special.host:14/queuey"; - String remaining = "special.host:14/queuey"; RabbitMQComponent comp = context.getComponent("rabbitmq", RabbitMQComponent.class); comp.setAutoDetectConnectionFactory(false); diff --git a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/RabbitMQServiceFactory.java b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/RabbitMQServiceFactory.java index 34b630d..4f5fc70 100644 --- a/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/RabbitMQServiceFactory.java +++ b/components/camel-rabbitmq/src/test/java/org/apache/camel/component/rabbitmq/test/infra/services/RabbitMQServiceFactory.java @@ -18,12 +18,8 @@ package org.apache.camel.component.rabbitmq.test.infra.services; import org.apache.camel.test.infra.rabbitmq.services.RabbitMQService; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public final class RabbitMQServiceFactory { - private static final Logger LOG = LoggerFactory.getLogger(RabbitMQServiceFactory.class); - private RabbitMQServiceFactory() { } diff --git a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/ClusteredJdbcAggregationRepository.java b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/ClusteredJdbcAggregationRepository.java index b65f35d..4c8f6dc 100644 --- a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/ClusteredJdbcAggregationRepository.java +++ b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/ClusteredJdbcAggregationRepository.java @@ -138,7 +138,7 @@ public class ClusteredJdbcAggregationRepository extends JdbcAggregationRepositor final CamelContext camelContext, final String key, final Exchange exchange, final String sql, final Long version, final boolean completed) throws Exception { - final byte[] data = codec.marshallExchange(camelContext, exchange, allowSerializedHeaders); + final byte[] data = codec.marshallExchange(exchange, allowSerializedHeaders); Integer insertCount = super.jdbcTemplate.execute(sql, new AbstractLobCreatingPreparedStatementCallback(getLobHandler()) { @Override diff --git a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java index 39a7af5..4e72378 100644 --- a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java +++ b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java @@ -34,7 +34,6 @@ import org.apache.camel.CamelContext; import org.apache.camel.Exchange; import org.apache.camel.RuntimeCamelException; import org.apache.camel.spi.OptimisticLockingAggregationRepository; -import org.apache.camel.spi.OptimisticLockingAggregationRepository.OptimisticLockingException; import org.apache.camel.spi.RecoverableAggregationRepository; import org.apache.camel.support.service.ServiceSupport; import org.apache.camel.util.ObjectHelper; @@ -277,7 +276,7 @@ public class JdbcAggregationRepository extends ServiceSupport protected int insertHelper( final CamelContext camelContext, final String key, final Exchange exchange, String sql, final Long version) throws Exception { - final byte[] data = codec.marshallExchange(camelContext, exchange, allowSerializedHeaders); + final byte[] data = codec.marshallExchange(exchange, allowSerializedHeaders); Integer insertCount = jdbcTemplate.execute(sql, new AbstractLobCreatingPreparedStatementCallback(getLobHandler()) { @Override @@ -303,7 +302,7 @@ public class JdbcAggregationRepository extends ServiceSupport protected int updateHelper( final CamelContext camelContext, final String key, final Exchange exchange, String sql, final Long version) throws Exception { - final byte[] data = codec.marshallExchange(camelContext, exchange, allowSerializedHeaders); + final byte[] data = codec.marshallExchange(exchange, allowSerializedHeaders); Integer updateCount = jdbcTemplate.execute(sql, new AbstractLobCreatingPreparedStatementCallback(getLobHandler()) { @Override diff --git a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcCamelCodec.java b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcCamelCodec.java index 3af195b..1edf333 100644 --- a/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcCamelCodec.java +++ b/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcCamelCodec.java @@ -38,15 +38,15 @@ import org.apache.camel.util.IOHelper; */ public class JdbcCamelCodec { - public byte[] marshallExchange(CamelContext camelContext, Exchange exchange, boolean allowSerializedHeaders) + public byte[] marshallExchange(Exchange exchange, boolean allowSerializedHeaders) throws IOException { ByteArrayOutputStream bytesOut = new ByteArrayOutputStream(); - marshallExchange(camelContext, exchange, allowSerializedHeaders, bytesOut); + marshallExchange(exchange, allowSerializedHeaders, bytesOut); return bytesOut.toByteArray(); } public void marshallExchange( - CamelContext camelContext, Exchange exchange, boolean allowSerializedHeaders, OutputStream outputStream) + Exchange exchange, boolean allowSerializedHeaders, OutputStream outputStream) throws IOException { // use DefaultExchangeHolder to marshal to a serialized object DefaultExchangeHolder pe = DefaultExchangeHolder.marshal(exchange, false, allowSerializedHeaders); diff --git a/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/AbstractClusteredJdbcAggregationTestSupport.java b/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/AbstractClusteredJdbcAggregationTestSupport.java index 649c3ea..01f2b7a 100644 --- a/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/AbstractClusteredJdbcAggregationTestSupport.java +++ b/components/camel-sql/src/test/java/org/apache/camel/processor/aggregate/jdbc/AbstractClusteredJdbcAggregationTestSupport.java @@ -38,10 +38,6 @@ public abstract class AbstractClusteredJdbcAggregationTestSupport extends CamelS void configureJdbcAggregationRepository() { } - long getCompletionInterval() { - return 5000; - } - @Override protected AbstractApplicationContext createApplicationContext() { return newAppContext( diff --git a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramServiceRestBotAPIAdapter.java b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramServiceRestBotAPIAdapter.java index 73421e3..e70c39d 100644 --- a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramServiceRestBotAPIAdapter.java +++ b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramServiceRestBotAPIAdapter.java @@ -155,7 +155,6 @@ public class TelegramServiceRestBotAPIAdapter implements TelegramService { try { final Response response = asyncHttpClient.executeRequest(request).get(); int code = response.getStatusCode(); - String status = response.getStatusText(); if (code >= 200 && code < 300) { try { final String responseBody = response.getResponseBody(); diff --git a/components/camel-zookeeper-master/src/main/java/org/apache/camel/component/zookeepermaster/group/internal/ZooKeeperMultiGroup.java b/components/camel-zookeeper-master/src/main/java/org/apache/camel/component/zookeepermaster/group/internal/ZooKeeperMultiGroup.java index 5792a78..ce3555c 100644 --- a/components/camel-zookeeper-master/src/main/java/org/apache/camel/component/zookeepermaster/group/internal/ZooKeeperMultiGroup.java +++ b/components/camel-zookeeper-master/src/main/java/org/apache/camel/component/zookeepermaster/group/internal/ZooKeeperMultiGroup.java @@ -24,11 +24,8 @@ import java.util.concurrent.ThreadFactory; import org.apache.camel.component.zookeepermaster.group.MultiGroup; import org.apache.camel.component.zookeepermaster.group.NodeState; import org.apache.curator.framework.CuratorFramework; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; public class ZooKeeperMultiGroup<T extends NodeState> extends ZooKeeperGroup<T> implements MultiGroup<T> { - private final Logger log = LoggerFactory.getLogger(getClass()); public ZooKeeperMultiGroup(CuratorFramework client, String path, Class<T> clazz) { super(client, path, clazz); diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/cloud/integration/ZooKeeperServiceCallRouteIT.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/cloud/integration/ZooKeeperServiceCallRouteIT.java index d567932..ea5a5f4 100644 --- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/cloud/integration/ZooKeeperServiceCallRouteIT.java +++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/cloud/integration/ZooKeeperServiceCallRouteIT.java @@ -41,7 +41,6 @@ public class ZooKeeperServiceCallRouteIT extends CamelTestSupport { @RegisterExtension static ZooKeeperService service = ZooKeeperServiceFactory.createService(); - private static final int SERVER_PORT = AvailablePortFinder.getNextAvailable(); private static final String SERVICE_NAME = "http-service"; private static final int SERVICE_COUNT = 5; private static final String SERVICE_PATH = "/camel"; diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/integration/ZooKeeperITSupport.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/integration/ZooKeeperITSupport.java index c5cf2d9..9427f0a 100644 --- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/integration/ZooKeeperITSupport.java +++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/integration/ZooKeeperITSupport.java @@ -170,7 +170,7 @@ public class ZooKeeperITSupport extends CamelTestSupport { } } - protected void verifyAccessControlList(String node, List<ACL> expected) throws Exception { + protected void verifyAccessControlList(String node) throws Exception { getConnection().getACL(node, new Stat()); } diff --git a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/integration/CreateOperationIT.java b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/integration/CreateOperationIT.java index 2f471ba..8722950 100644 --- a/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/integration/CreateOperationIT.java +++ b/components/camel-zookeeper/src/test/java/org/apache/camel/component/zookeeper/operations/integration/CreateOperationIT.java @@ -109,6 +109,6 @@ public class CreateOperationIT extends ZooKeeperITSupport { OperationResult<String> result = create.get(); assertEquals("/four", result.getResult()); - verifyAccessControlList("/four", perms); + verifyAccessControlList("/four"); } }