zregvart commented on code in PR #825: URL: https://github.com/apache/camel-website/pull/825#discussion_r850245789
########## yarn-in-docker.sh: ########## @@ -5,4 +5,4 @@ # $yarn-in-docker.sh workspace antora-ui-camel run build docker build -t camel-website . -docker run --rm -it -v $(pwd):/work:Z --workdir /work camel-website yarn $* +docker run --rm -it --env-file yarn-in-docker.env -v $(pwd):/work:Z --workdir /work camel-website yarn $* Review Comment: I'm okay either way. My motivation was simplicity. We most likely won't be adding new environment variables and we'll remove the support for `HUGO_PARAMS_GitHub*` environment variables in the future, so having two `-e` parameters and having those be inherited from the shell seemed simpler to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
