aldettinger commented on code in PR #3759:
URL: https://github.com/apache/camel-quarkus/pull/3759#discussion_r866023121
##########
integration-tests/paho/src/main/java/org/apache/camel/quarkus/component/paho/PahoResource.java:
##########
@@ -125,6 +125,21 @@ public String
readThenWriteWithFilePersistenceShouldSucceed(@QueryParam("message
String.class);
}
+ @Path("/sendReceiveWithRfc3986AuthorityShouldSucceed")
+ @GET
+ @Produces(MediaType.TEXT_PLAIN)
+ public String
sendReceiveWithRfc3986AuthorityShouldSucceed(@QueryParam("message") String
message) {
+
+ // Change the brokerUrl to an RFC3986 form
+ String tcpUrl =
ConfigProvider.getConfig().getValue("paho.broker.tcp.url", String.class);
+ tcpUrl = tcpUrl.replaceAll("tcp://([^:]*):(.*)",
"tcp://user:password@$1:$2");
Review Comment:
@zhfeng Many thanks for review :+1: As it stands, the purpose of this test
is not to have `user` and `password` actually used. We are using dummy `user`
and `password` values because the purpose is just to check that we don't hit
[those
lines](https://github.com/eclipse/paho.mqtt.java/blob/master/org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/internal/NetworkModuleService.java#L137-L140)
when using RFC 3986 style URL.
Does it make more sense now ? What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
