tadayosi commented on code in PR #3363:
URL: https://github.com/apache/camel-k/pull/3363#discussion_r898722496
##########
pkg/resources/resources_support.go:
##########
@@ -146,3 +148,11 @@ func Resources(dirName string) ([]string, error) {
return res, dir.Close()
}
+
+func fixPath(path string) string {
Review Comment:
~And since `assets.Open(filepath.ToSlash(path))` needs to be invoked every
time as a set, why don't we insert the path fixing code inside the `Open`
method directly here instead?~
https://github.com/apache/camel-k/blob/main/pkg/resources/resources.go#L717
OK, `resources.go` is a generated file by vfsgen and it's not good idea to
manually edit it. So at best we can only extract a function for the combination
of `assets.Open(filepath.ToSlash(path))` like `func openAssets(path)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
