tadayosi commented on code in PR #3480:
URL: https://github.com/apache/camel-k/pull/3480#discussion_r930583574
##########
pkg/controller/integration/kits.go:
##########
@@ -82,6 +82,18 @@ func lookupKitsForIntegration(ctx context.Context, c
ctrl.Reader, integration *v
return kits, nil
}
+// sameOrMatch returns whether the v1.IntegrationKit ios the one used by the
v1.Integration or if it meets the
+// requirements of the v1.Integration.
+func sameOrMatch(kit *v1.IntegrationKit, integration *v1.Integration) (bool,
error) {
Review Comment:
I think this func is a necessary one to have, but also wonder if
`integrationMatches()` should be aware of the traits in annotations as well.
Currently `integrationMatches()` only compares `it.spec.traits` with
`kit.spec.traits` but shouldn't it really compare them using the combination of
annotations and spec.traits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
