aldettinger commented on PR #3919: URL: https://github.com/apache/camel-quarkus/pull/3919#issuecomment-1208402165
> > Checking the feature [coverage](https://camel.apache.org/components/3.18.x/google-pubsub-component.html): > > > > * Producers => OK > > * Consumers => OK > > * Message body => OK > > * AUTHENTICATION CONFIGURATION => I'm not sure ? > > * ROLLBACK AND REDELIVERY => I think it is covered by the ACK test ? > > est ? > > yes > > > Paying attention to the native test coverage of authentication might be a good investment. For instance, there are some reflections logic used in google's [DefaultCredentialsProvider](https://github.com/googleapis/google-auth-library-java/blob/main/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java#L254-L269). I wonder if users could hit that ? > > I didn't check this google source, I agree that this code should be covered more carefully. I'll revisit authentication case again, because it could be possible, that I removed some coe, which was covering part of this use case during refactoring. (without noticing it is important) @JiriOndrusek That could be the subject of another ticket ? What do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
