christophd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331920845
The changes should not harm existing runtimes and integrations. The operator may build a new integration kit because of the additional utils dependency but that should be all. The YAKS tests that we have should make sure that the DDB sink Kamelet is still working as it was before. I have not changed the tests and they run successful in this PR. Also we have new YAKS tests for AWS S3 source that also verify the default behavior of the Kamelet as it has been before. @oscerd @lburgazzoli I think we can wait for the end of the day and then make a decision. I can work on some of the open points today so we should only have these left overs that we can tackle in follow-up iterations: - Make factory finder mechanism work in camel-quarkus (may lead to a new Camel K release) - Disable classpath scan by default and use lazy loading via factory finder as a result of the point above - Generate factory finder META-INF files as done in Camel core - Add DataTypeRegistry as singleton to the Camel registry to avoid local instances per Kamelet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
