essobedo commented on code in PR #9210:
URL: https://github.com/apache/camel/pull/9210#discussion_r1087527872


##########
components/camel-atmosphere-websocket/src/main/java/org/apache/camel/component/atmosphere/websocket/WebsocketEndpoint.java:
##########
@@ -86,15 +86,15 @@ public void setSendToAll(boolean sendToAll) {
         this.sendToAll = sendToAll;
     }
 
-    public boolean isUseStreaming() {
-        return useStreaming;
+    public boolean isStreaming() {
+        return streaming;
     }
 
     /**
      * To enable streaming to send data as multiple text fragments.
      */
-    public void setUseStreaming(boolean useStreaming) {
-        this.useStreaming = useStreaming;
+    public void setStreaming(boolean streaming) {

Review Comment:
   I'm sorry but I'm a bit concerned about the fact that we impact end users by 
renaming a property because for an unknown reason it "fixes" a test. Renaming 
the property is just a workaround, it doesn't really fix the problem that needs 
to be addressed as it could be potentially major.
   
   Could you please describe the problem you met in 
https://issues.apache.org/jira/browse/CAMEL-18978 instead of describing the 
solution, just to be sure that we are not facing an XY problem and to allow us 
to understand the problem.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to