squakez commented on code in PR #4021:
URL: https://github.com/apache/camel-k/pull/4021#discussion_r1093325234
##########
pkg/builder/types.go:
##########
@@ -80,6 +80,7 @@ type builderContext struct {
Build v1.BuilderTask
BaseImage string
Namespace string
+ Integration string
Review Comment:
I think this is breaking the original design that wants an IntegrationKit
(and the related build) to be Integration agnostic in order to be reused. If
you need the source at build time (which I suspect is the reason why you want
to provide an Integration here), probably we need to think an alternative way
of generating the project to be given to the builder and let also the runtime
to manage that situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
