davsclaus commented on code in PR #9302:
URL: https://github.com/apache/camel/pull/9302#discussion_r1096502888
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JsonDataFormat.java:
##########
@@ -601,6 +614,16 @@ public Builder contentTypeHeader(boolean
contentTypeHeader) {
return this;
}
+ public Builder dateFormatPattern(String dateFormatPattern) {
Review Comment:
Can you add javadoc with: To configure the date format while marshall or
unmarshall Date fields in JSON using Gson
to the builder methods
##########
components/camel-gson/src/test/resources/org/apache/camel/component/gson/SpringGsonJsonDataFormatTest.xml:
##########
@@ -56,6 +57,17 @@
<to uri="mock:reversePojo"/>
</route>
+ <route>
+ <from uri="direct:inFormatDate"/>
+ <marshal><custom ref="format_date"/></marshal>
+ </route>
+
+ <route>
Review Comment:
Would be nice to format this XML correctly
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JsonDataFormat.java:
##########
@@ -601,6 +614,16 @@ public Builder contentTypeHeader(boolean
contentTypeHeader) {
return this;
}
+ public Builder dateFormatPattern(String dateFormatPattern) {
Review Comment:
And frankly we likely forgot to do that on other builder methods. If you
spot those, you are welcome to send another PR to update those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
