astefanutti commented on code in PR #4064:
URL: https://github.com/apache/camel-k/pull/4064#discussion_r1109420021
##########
pkg/controller/integration/integration_controller.go:
##########
@@ -55,6 +57,16 @@ import (
)
func Add(mgr manager.Manager, c client.Client) error {
+ err := mgr.GetFieldIndexer().IndexField(context.Background(),
&corev1.Pod{}, "status.phase",
Review Comment:
I've checked and the context is used to cancel wait on informer(s)
synchronisation. It'll probably work 99% of the time, but for correctness, it
may be better to use `ctrl.SetupSignalHandler()` or find a way to pass the
parent context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
