orpiske commented on code in PR #9939:
URL: https://github.com/apache/camel/pull/9939#discussion_r1178111915
##########
components/camel-as2/camel-as2-component/src/test/java/org/apache/camel/component/as2/MendelsonCertLoader.java:
##########
@@ -0,0 +1,183 @@
+package org.apache.camel.component.as2;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.KeyStore;
+import java.security.KeyStoreException;
+import java.security.NoSuchAlgorithmException;
+import java.security.PrivateKey;
+import java.security.UnrecoverableKeyException;
+import java.security.cert.Certificate;
+import java.security.cert.CertificateException;
+import java.security.cert.CertificateFactory;
+import java.security.spec.InvalidKeySpecException;
+import java.util.ArrayList;
+import java.util.Base64;
+import java.util.List;
+
+import javax.net.ssl.SSLContext;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.http.conn.ssl.TrustAllStrategy;
+import org.apache.http.ssl.SSLContexts;
+
+/**
+ * That's a utility class for preparing Mendelson-specific certificate chain,
private key, ssl context
+ */
+public class MendelsonCertLoader {
Review Comment:
What I am considering here is: if this is disabled, it won't be tested
often. If it won't be tested often, the code will rot and it will be upon us
(maintainers/committers) to figure out - several months in the future - if it's
still relevant or not (and, as things change, certificates get expired, etc)
it's one hell of a pain to update and fix things on these obscure technologies.
So, by making it generic and configurable ... users themselves can handle
this and put more burden on the maintainers.
I am -1 on this, but let's see what others have to say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
