ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1594287508
The failure in the checkstyle job is interesting for two reasons: 1. `checkstyle:checkstyle` requires resolved dependencies and because it runs before any `install` and because `https://repository.apache.org/snapshots/` are enabled by default, `checkstyle:checkstyle` pulls snapshots. I'd say CI should be reproducible and therefore should not rely on any snapshots other than local ones built from the current commit. 2. Rather than fixing the above, I wonder whether we still need checkstyle at all? I used to be a fan of it back in times when formatter and impsort plugins did not exist. But since I know the two, I tend to hate checkstyle. It just complains and cannot fix even basic things. Would anybody veto removing checkstyle and enabling formatter and impsort plugins as a part of the default build? This would also reduce the amount of clutter in the git history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
