[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5024: Micrometer: SimpleMeterRegistry is not created if no other registry is defined #5023

[via GitHub]

jamesnetherton commented on PR #5024:
URL: https://github.com/apache/camel-quarkus/pull/5024#issuecomment-1612555899

   I don't think we need to create `MicrometerRegistryProviderBuildItem`, we 
only need to consume them.
   
   So I was thinking something like:
   
   ```java
   @BuildStep
   void configureDefaultRegistry(
           List<MicrometerRegistryProviderBuildItem> providers, 
           RootMeterRegistryBuildItem registry,
           CamelMicrometerRecorder recorder) {
       if (providers.isEmpty()) {
           // Adds SimpleMeterRegistry to the Quarkus composite one
           recorder.configureDefaultRegistry(registry.getValue());
       }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org