gansheer commented on code in PR #4568:
URL: https://github.com/apache/camel-k/pull/4568#discussion_r1262354188
##########
pkg/builder/project.go:
##########
@@ -191,3 +194,14 @@ func injectDependencies(ctx *builderContext) error {
func sanitizeDependencies(ctx *builderContext) error {
return
camel.SanitizeIntegrationDependencies(ctx.Maven.Project.Dependencies)
}
+
+func injectProfile(ctx *builderContext) error {
Review Comment:
I analyzed this option. There is a way to use an external file but it will
limit the build functionnalities overides from the profile as stated in [the
maven
documentation](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#which-areas-of-a-pom-can-be-customized-by-each-type-of-profile-w).
In short any profile in an external file would only be able to modify the
`<repositories>` and `<pluginRepositories>` sections, plus an extra
<properties> section, whereas an inlined profile in the POM will be able the
full spec of a profile. This is a design decision from maven.
This is the reason I decided to inject the content into the pom file. Let me
know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
