gansheer commented on code in PR #4793:
URL: https://github.com/apache/camel-k/pull/4793#discussion_r1347339554


##########
pkg/controller/integration/monitor.go:
##########
@@ -81,6 +81,12 @@ func (action *monitorAction) Handle(ctx context.Context, 
integration *v1.Integra
                        integration.Status.IntegrationKit.Namespace, 
integration.Status.IntegrationKit.Name, err)
        }
 
+       // If integration is in error and its kit is also in error then 
integration does not change
+       if isInIntegrationKitFailed(integration.Status) &&

Review Comment:
   It actually works, because if we change the Integration CR then a new 
integration kit gets created and built. I will add this in the test.
   
   Is there a case where the IntegrationKit could be fixed without any change 
the Integration CR ?
   Also, is there a case where the Integration get changed but it does not 
change the IntegrationKit ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to