CodeSmell commented on code in PR #11959: URL: https://github.com/apache/camel/pull/11959#discussion_r1390232215
########## components/camel-kafka/src/test/java/org/apache/camel/component/kafka/integration/KafkaBreakOnFirstErrorSeekIssueIT.java: ########## @@ -0,0 +1,146 @@ +package org.apache.camel.component.kafka.integration; + +import org.apache.camel.Endpoint; +import org.apache.camel.EndpointInject; +import org.apache.camel.Exchange; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.kafka.MockConsumerInterceptor; +import org.apache.camel.component.kafka.testutil.CamelKafkaUtil; +import org.apache.camel.component.mock.MockEndpoint; +import org.apache.kafka.clients.admin.NewTopic; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.awaitility.Awaitility; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Collections; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.TimeUnit; + + +/** + * this will test breakOnFirstError functionality + * and the issue that was surfaced in CAMEL-19894 + * regarding failure to correctly commit the offset + * in a batch using the Synch Commit Manager + * + * mimics the reproduction of the problem in + * https://github.com/Krivda/camel-bug-reproduction + */ +class KafkaBreakOnFirstErrorSeekIssueIT extends BaseEmbeddedKafkaTestSupport { + Review Comment: That's correct. This test will fail as-is. I have not had a chance to look at the infra test to get the partitions increased. The same test is in my personal repo (link above). That was passing when I ran it with my local build of the camel-kafka component with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
