mvolf commented on code in PR #992:
URL: https://github.com/apache/camel-karavan/pull/992#discussion_r1400565003
##########
karavan-web/karavan-app/src/main/webui/src/api/ProjectService.ts:
##########
@@ -258,7 +258,6 @@ export class ProjectService {
public static copyProject(sourceProject: string, project: Project) {
KaravanApi.copyProject(sourceProject, project, res => {
if (res.status === 200 || res.status === 201) {
- EventBus.sendAlert( 'Success', 'Project copied', 'success');
Review Comment:
I agree, but I again followed the implementation used in the create project
action, which doesn't throw an exception if the existing project-id is sent,
but just the sent project.
I can change this implementation and throw an exception when needed, but it
won't follow the create project behaviour in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
