squakez commented on code in PR #5109:
URL: https://github.com/apache/camel-k/pull/5109#discussion_r1467362812
##########
pkg/cmd/operator/operator.go:
##########
@@ -295,7 +295,8 @@ func getOperatorImage(ctx context.Context, c ctrl.Reader)
(string, error) {
ns := platform.GetOperatorNamespace()
name := platform.GetOperatorPodName()
if ns == "" || name == "" {
- return "", nil
+ // We are most likely running out of cluster. Let's take a
chance and use the default value
Review Comment:
I think the previous assumption was correct. I mean, if we're running out of
cluster, then, the software binary is not distributed in a container image. If
we enable this, then, we would trick the operator to think that it is running
from a container, for example, enabling the possibility to run pipeline in a
pod (which would instead spin off the `kamel builder` from a distribution that
is different from the running application). IMO, we must return as empty, as
also claimed in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
