kulagaIA commented on code in PR #12943: URL: https://github.com/apache/camel/pull/12943#discussion_r1469799358
########## components/camel-platform-http-vertx/src/main/java/org/apache/camel/component/platform/http/vertx/auth/AuthenticationConfig.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.platform.http.vertx.auth; + +import java.util.ArrayList; +import java.util.List; + +import io.vertx.core.Handler; +import io.vertx.core.Vertx; +import io.vertx.ext.auth.authentication.AuthenticationProvider; +import io.vertx.ext.auth.properties.PropertyFileAuthentication; +import io.vertx.ext.web.RoutingContext; +import io.vertx.ext.web.handler.AuthenticationHandler; +import io.vertx.ext.web.handler.BasicAuthHandler; + +public class AuthenticationConfig { + public static final String DEFAULT_VERTX_PROPERTIES_FILE = "camel-platform-http-vertx-auth.properties"; + private boolean authenticationEnabled; + private List<AuthenticationConfigEntry> entries; Review Comment: Big thanks for reading through my code! :) Agree, but I think it will be inconvenient to have a final authentication field, because sometimes we want to create AuthenticationConfig first, and then populate it later. For example, this is how it is done in MainHttpServer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
