squakez commented on code in PR #5154: URL: https://github.com/apache/camel-k/pull/5154#discussion_r1487579446
########## pkg/metrics/metrics.go: ########## @@ -0,0 +1,36 @@ +package metrics Review Comment: I think we should reuse instead the existing https://github.com/apache/camel-k/blob/main/pkg/controller/integration/metrics.go ########## pkg/controller/integration/integration_controller.go: ########## @@ -534,6 +536,8 @@ func (r *reconcileIntegration) Reconcile(ctx context.Context, request reconcile. } } + metrics.UpdateIntegrationPhase(instance.Name, string(instance.Status.Phase)) Review Comment: I think this would fit instead in https://github.com/apache/camel-k/blob/7ba6c99754f3fb826003df4e1f922890bca224ca/pkg/controller/integration/integration_controller.go#L88 as we already do for the readiness metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
