lsergio commented on issue #5223:
URL: https://github.com/apache/camel-k/issues/5223#issuecomment-1980952929
Investigating a little further, I see that I cannot even set a percentage
value explicitly:
```
deployment:
strategy: RollingUpdate
rollingUpdateMaxSurge: 10%
rollingUpdateMaxUnavailable: 10%
```
This issues the error:
```
* spec.traits.deployment.rollingUpdateMaxSurge: Invalid value: "string":
spec.traits.deployment.rollingUpdateMaxSurge in body must be of type integer:
"string"
* spec.traits.deployment.rollingUpdateMaxUnavailable: Invalid value:
"string": spec.traits.deployment.rollingUpdateMaxUnavailable in body must be of
type integer: "string"
*
```
So we would also have to change the type of these variables from int to
string:
```
// The maximum number of pods that can be unavailable during the update.
// Value can be an absolute number (ex: 5) or a percentage of desired
pods (ex: 10%).
// Absolute number is calculated from percentage by rounding down.
// This can not be 0 if MaxSurge is 0.
// Defaults to `25%`.
RollingUpdateMaxUnavailable *int
`property:"rolling-update-max-unavailable"
json:"rollingUpdateMaxUnavailable,omitempty"`
// The maximum number of pods that can be scheduled above the desired
number of
// pods.
// Value can be an absolute number (ex: 5) or a percentage of desired
pods (ex: 10%).
// This can not be 0 if MaxUnavailable is 0.
// Absolute number is calculated from percentage by rounding up.
// Defaults to `25%`.
RollingUpdateMaxSurge *int `property:"rolling-update-max-surge"
json:"rollingUpdateMaxSurge,omitempty"`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
