romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526321406


##########
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##########
@@ -228,8 +232,21 @@ public void onFailure(Exchange exchange) {
             if (cause != null) {
                 getExceptionHandler().handleException("Error during processing 
exchange.", exchange, cause);
             }
+
             if (!getConfiguration().isDisableAutoComplete()) {
-                
clientWrapper.abandon(message).subscribeOn(Schedulers.boundedElastic()).subscribe();
+                if (getConfiguration().isEnableDeadLettering()) {

Review Comment:
   I've just removed my precedent comment as it was not correct.
   
   According to the [Azure ServiceBus 
documentation](https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-dead-letter-queues)
   "Azure Service Bus queues and topic subscriptions provide a secondary 
subqueue, called a dead-letter queue"
   So every queue or subscription has a deadletter.
   
   but you are right, is the consumer is already consuming subqueue, we cannot 
deadletter the message. So I need to check if the subQueue option is set
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to