squakez commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530239825
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -483,18 +488,32 @@ private void addCapabilities(RuntimeSpec.Builder
runtimeSpec, CamelCatalogSpec.B
artifacts.add(Artifact.from("org.apache.camel.quarkus",
"camel-quarkus-opentracing"));
addCapabilityAndDependecies(runtimeSpec, catalogSpec, "tracing",
artifacts, false);
+ // Telemetry capability
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus",
"camel-quarkus-opentelemetry"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "telemetry",
artifacts, false);
-
- artifacts.clear();
- artifacts.add(Artifact.from("org.apache.camel.k", "camel-k-master"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "master",
artifacts, true);
+ properties.clear();
+ properties.add(Property.from("endpoint",
"quarkus.opentelemetry.tracer.exporter.otlp.endpoint"));
+ properties.add(Property.from("serviceName",
"quarkus.opentelemetry.tracer.resource-attributes"));
+ properties.add(Property.from("sampler",
"quarkus.opentelemetry.tracer.sampler"));
+ properties.add(Property.from("samplerRatio",
"quarkus.opentelemetry.tracer.sampler.ratio"));
+ properties.add(Property.from("samplerParentBased",
"quarkus.opentelemetry.tracer.sampler.parent-based"));
Review Comment:
I acknowledge them but this PR doesn't aim to solve this aspect. This is
something we need to address regardless this PR. Do you think that challenge
can be tackled separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
