christophd commented on code in PR #13686:
URL: https://github.com/apache/camel/pull/13686#discussion_r1549468087
##########
dsl/camel-yaml-dsl/camel-yaml-dsl/src/main/java/org/apache/camel/dsl/yaml/YamlRoutesBuilderLoader.java:
##########
@@ -112,7 +112,7 @@ public class YamlRoutesBuilderLoader extends
YamlRoutesBuilderLoaderSupport {
@Deprecated
private static final String BINDING_VERSION = "camel.apache.org/v1alpha1";
private static final String PIPE_VERSION = "camel.apache.org/v1";
- private static final String STRIMZI_VERSION = "kafka.strimzi.io/v1";
+ private static final String STRIMZI_VERSION = "kafka.strimzi.io/v1beta2";
Review Comment:
In theory Strimzi team could rename/delete the custom resource from
KafkaTopic to something different in v1 but that is not very likely to happen.
So the idea to match just `kafka.strimzi.io` sounds good to me (I will work on
it on a separate PR).
I think for the bind command where the Pipe is created by Camel we still
need to stick to a specific version that is used by default. Users can always
bind to a fully custom object reference providing the full resource identifier
such as `kafka.strimzi.io/v1:KafkaTopic:my-topic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
