gansheer commented on code in PR #5321:
URL: https://github.com/apache/camel-k/pull/5321#discussion_r1553198633


##########
pkg/cmd/operator/operator.go:
##########
@@ -201,22 +202,27 @@ func Run(healthPort, monitoringPort int32, leaderElection 
bool, leaderElectionID
                }
        }
 
+       defaultNamespaces := map[string]cache.Config{
+               operatorNamespace: {},

Review Comment:
   It's a little more complex than that. As per this 
[discussion](https://github.com/kubernetes-sigs/controller-runtime/issues/2456#issuecomment-1774118374)
 the  CRDs are expected to be installed when we configure the cache.
   
   I think I may need to remove `&servingv1.Service{}` from the selectors as it 
is not always installed. I could do conditional addition of 
`&servingv1.Service{}`  but that suppose any change in the presence of the CRD 
will mean re-creation of the operator pod(s).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to