gnodet commented on code in PR #13823:
URL: https://github.com/apache/camel/pull/13823#discussion_r1568243577


##########
core/camel-core-model/src/main/java/org/apache/camel/model/NoOutputDefinition.java:
##########
@@ -29,4 +29,10 @@ public List<ProcessorDefinition<?>> getOutputs() {
         return Collections.emptyList();
     }
 
+    public NoOutputDefinition() {
+    }
+
+    NoOutputDefinition(NoOutputDefinition source) {

Review Comment:
   Should all the copy constructors be  `protected` rather than package private 
? This won't change much as afaik all the models are in the same package, but 
the idea of this constructor is that it will be called by children classes, so 
protected makes more sense here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to