(camel) 08/08: (chores) camel-core: code cleanup

[orpiske]

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 028b6fb743d621e53d6455f9f6d7b6184a70a56d
Author: Otavio Rodolfo Piske <angusyo...@gmail.com>
AuthorDate: Tue Apr 23 11:58:14 2024 +0200

    (chores) camel-core: code cleanup
    
    Use simpler collections operations
---
 .../org/apache/camel/catalog/EndpointValidationResult.java   |  4 +---
 .../org/apache/camel/catalog/PropertiesValidationResult.java |  4 +---
 .../java/org/apache/camel/util/CaseInsensitiveMapTest.java   | 12 ++++++------
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git 
a/core/camel-api/src/main/java/org/apache/camel/catalog/EndpointValidationResult.java
 
b/core/camel-api/src/main/java/org/apache/camel/catalog/EndpointValidationResult.java
index c674f915561..3bfbec6b2ce 100644
--- 
a/core/camel-api/src/main/java/org/apache/camel/catalog/EndpointValidationResult.java
+++ 
b/core/camel-api/src/main/java/org/apache/camel/catalog/EndpointValidationResult.java
@@ -59,9 +59,7 @@ public class EndpointValidationResult extends 
PropertiesValidationResult impleme
         if (lenient == null) {
             lenient = new LinkedHashSet<>();
         }
-        if (!lenient.contains(name)) {
-            lenient.add(name);
-        }
+        lenient.add(name);
     }
 
     public void addNotConsumerOnly(String name) {
diff --git 
a/core/camel-api/src/main/java/org/apache/camel/catalog/PropertiesValidationResult.java
 
b/core/camel-api/src/main/java/org/apache/camel/catalog/PropertiesValidationResult.java
index d6303663a01..115a420113a 100644
--- 
a/core/camel-api/src/main/java/org/apache/camel/catalog/PropertiesValidationResult.java
+++ 
b/core/camel-api/src/main/java/org/apache/camel/catalog/PropertiesValidationResult.java
@@ -128,9 +128,7 @@ abstract class PropertiesValidationResult implements 
Serializable {
         if (deprecated == null) {
             deprecated = new LinkedHashSet<>();
         }
-        if (!deprecated.contains(name)) {
-            deprecated.add(name);
-        }
+        deprecated.add(name);
     }
 
     private String computeErrors(String value) {
diff --git 
a/core/camel-core/src/test/java/org/apache/camel/util/CaseInsensitiveMapTest.java
 
b/core/camel-core/src/test/java/org/apache/camel/util/CaseInsensitiveMapTest.java
index 68af18d0531..27cb86dcd9b 100644
--- 
a/core/camel-core/src/test/java/org/apache/camel/util/CaseInsensitiveMapTest.java
+++ 
b/core/camel-core/src/test/java/org/apache/camel/util/CaseInsensitiveMapTest.java
@@ -311,11 +311,11 @@ public class CaseInsensitiveMapTest {
         assertTrue(map.containsKey("foo"));
         assertTrue(map.containsKey("FOO"));
 
-        assertTrue(map.keySet().contains("FOO"));
-        assertTrue(map.keySet().contains("FoO"));
-        assertTrue(map.keySet().contains("Foo"));
-        assertTrue(map.keySet().contains("foo"));
-        assertTrue(map.keySet().contains("fOO"));
+        assertTrue(map.containsKey("FOO"));
+        assertTrue(map.containsKey("FoO"));
+        assertTrue(map.containsKey("Foo"));
+        assertTrue(map.containsKey("foo"));
+        assertTrue(map.containsKey("fOO"));
 
         map.put("FOO", "cake");
         assertEquals(1, map.size());
@@ -335,7 +335,7 @@ public class CaseInsensitiveMapTest {
         assertTrue(map.containsKey("foo"));
         assertFalse(map.containsKey("FOO"));
 
-        assertFalse(map.keySet().contains("FOO"));
+        assertFalse(map.containsKey("FOO"));
 
         map.put("FOO", "cake");
         assertEquals(2, map.size());