This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit ada86a2c8a0de459e5006d0448ca9e7d11bf8d41 Author: Otavio Rodolfo Piske <angusyo...@gmail.com> AuthorDate: Thu Apr 25 11:39:55 2024 +0200 (chores) camel-core: use final when possible --- .../org/apache/camel/component/file/FileBeginFailureOneTimeTest.java | 2 +- .../apache/camel/component/file/FileConsumerCustomSchedulerTest.java | 2 +- .../src/test/java/org/apache/camel/impl/EndpointShutdownOnceTest.java | 2 +- .../org/apache/camel/processor/DeadLetterChannelNoRedeliveryTest.java | 2 +- .../camel/processor/RedeliveryErrorHandlerBlockedDelayTest.java | 2 +- .../camel/processor/RedeliveryErrorHandlerNonBlockedDelayTest.java | 2 +- .../RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.java | 2 +- .../apache/camel/processor/RedeliveryOnExceptionBlockedDelayTest.java | 2 +- .../java/org/apache/camel/processor/SetVariablesProcessorTest.java | 4 ++-- .../aggregator/AggregateSimpleExpressionIssueManualTest.java | 2 +- .../camel/processor/async/AsyncEndpointCustomRoutePolicyTest.java | 2 +- .../AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.java | 2 +- .../async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.java | 2 +- .../src/test/java/org/apache/camel/management/LoadTimerTest.java | 2 +- .../src/test/java/org/apache/camel/support/task/TaskTestSupport.java | 2 +- 15 files changed, 16 insertions(+), 16 deletions(-) diff --git a/core/camel-core/src/test/java/org/apache/camel/component/file/FileBeginFailureOneTimeTest.java b/core/camel-core/src/test/java/org/apache/camel/component/file/FileBeginFailureOneTimeTest.java index f4cc528c190..e09ad152f88 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/file/FileBeginFailureOneTimeTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/file/FileBeginFailureOneTimeTest.java @@ -64,7 +64,7 @@ public class FileBeginFailureOneTimeTest extends ContextTestSupport { private static class MyStrategy implements GenericFileProcessStrategy<File> { - private LongAdder invoked = new LongAdder(); + private final LongAdder invoked = new LongAdder(); @Override public void prepareOnStartup( diff --git a/core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerCustomSchedulerTest.java b/core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerCustomSchedulerTest.java index 735e462caf0..a48b8e1bc40 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerCustomSchedulerTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/file/FileConsumerCustomSchedulerTest.java @@ -72,7 +72,7 @@ public class FileConsumerCustomSchedulerTest extends ContextTestSupport { private CamelContext camelContext; private TimerTask timerTask; - private LongAdder counter = new LongAdder(); + private final LongAdder counter = new LongAdder(); private String foo; @Override diff --git a/core/camel-core/src/test/java/org/apache/camel/impl/EndpointShutdownOnceTest.java b/core/camel-core/src/test/java/org/apache/camel/impl/EndpointShutdownOnceTest.java index ddb63e0b1bc..c015c11dff6 100644 --- a/core/camel-core/src/test/java/org/apache/camel/impl/EndpointShutdownOnceTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/impl/EndpointShutdownOnceTest.java @@ -63,7 +63,7 @@ public class EndpointShutdownOnceTest { private static final class MyEndpoint extends DefaultEndpoint { - private LongAdder invoked = new LongAdder(); + private final LongAdder invoked = new LongAdder(); private MyEndpoint(String endpointUri, Component component) { super(endpointUri, component); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelNoRedeliveryTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelNoRedeliveryTest.java index 6f8fe66345a..3f045e539ad 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelNoRedeliveryTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/DeadLetterChannelNoRedeliveryTest.java @@ -31,7 +31,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; */ public class DeadLetterChannelNoRedeliveryTest extends ContextTestSupport { - private static LongAdder counter = new LongAdder(); + private static final LongAdder counter = new LongAdder(); @Test public void testDLCNoRedelivery() throws Exception { diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerBlockedDelayTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerBlockedDelayTest.java index 369424da82f..3f9e9ff6503 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerBlockedDelayTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerBlockedDelayTest.java @@ -31,7 +31,7 @@ public class RedeliveryErrorHandlerBlockedDelayTest extends ContextTestSupport { private static final Logger LOG = LoggerFactory.getLogger(RedeliveryErrorHandlerBlockedDelayTest.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); @Test public void testRedelivery() throws Exception { diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedDelayTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedDelayTest.java index e7bc686ee52..2da6ddd2208 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedDelayTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedDelayTest.java @@ -31,7 +31,7 @@ public class RedeliveryErrorHandlerNonBlockedDelayTest extends ContextTestSuppor private static final Logger LOG = LoggerFactory.getLogger(RedeliveryErrorHandlerNonBlockedDelayTest.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); @Test public void testRedelivery() throws Exception { diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.java index 0974b4ad74a..3491c24a7d2 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.java @@ -31,7 +31,7 @@ public class RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest extends Contex private static final Logger LOG = LoggerFactory.getLogger(RedeliveryErrorHandlerNonBlockedRedeliveryHeaderTest.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); @Test public void testRedelivery() throws Exception { diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryOnExceptionBlockedDelayTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryOnExceptionBlockedDelayTest.java index 9f2f368c790..b311fa9238a 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryOnExceptionBlockedDelayTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/RedeliveryOnExceptionBlockedDelayTest.java @@ -31,7 +31,7 @@ public class RedeliveryOnExceptionBlockedDelayTest extends ContextTestSupport { private static final Logger LOG = LoggerFactory.getLogger(RedeliveryOnExceptionBlockedDelayTest.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); @Test public void testRedelivery() throws Exception { diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/SetVariablesProcessorTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/SetVariablesProcessorTest.java index 95c8d9de2c9..c8bba506e8f 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/SetVariablesProcessorTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/SetVariablesProcessorTest.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class SetVariablesProcessorTest extends ContextTestSupport { public static class VarBean { - Map<String, String> map = new java.util.LinkedHashMap<>(); + final Map<String, String> map = new java.util.LinkedHashMap<>(); public VarBean() { } @@ -45,7 +45,7 @@ public class SetVariablesProcessorTest extends ContextTestSupport { } private final Map<String, Expression> varMap = new java.util.LinkedHashMap<>(); - protected String body = "<person name='Jane' age='10'/>"; + protected final String body = "<person name='Jane' age='10'/>"; protected MockEndpoint expected; @Test diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateSimpleExpressionIssueManualTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateSimpleExpressionIssueManualTest.java index 2b828f82434..ddd7d9c7229 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateSimpleExpressionIssueManualTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateSimpleExpressionIssueManualTest.java @@ -88,7 +88,7 @@ public class AggregateSimpleExpressionIssueManualTest extends ContextTestSupport } public static final class MyBean { - private LongAdder cnt = new LongAdder(); + private final LongAdder cnt = new LongAdder(); public void invoke(final List<String> strList) { cnt.increment(); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointCustomRoutePolicyTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointCustomRoutePolicyTest.java index f3255198973..d1750ccb3d3 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointCustomRoutePolicyTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointCustomRoutePolicyTest.java @@ -41,7 +41,7 @@ public class AsyncEndpointCustomRoutePolicyTest extends ContextTestSupport { private static class MyCustomRoutePolicy extends RoutePolicySupport { - private LongAdder invoked = new LongAdder(); + private final LongAdder invoked = new LongAdder(); private final AtomicBoolean stopped = new AtomicBoolean(); @Override diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.java b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.java index 5a309593e4c..a7737ab0867 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.java @@ -33,7 +33,7 @@ public class AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test extends Con private static final Logger LOG = LoggerFactory.getLogger(AsyncEndpointRedeliveryErrorHandlerNonBlockedDelay2Test.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); private static String beforeThreadName; private static String afterThreadName; diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.java index e7fd429512d..75b1ba854ad 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/async/AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.java @@ -33,7 +33,7 @@ public class AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest extends Cont private static final Logger LOG = LoggerFactory.getLogger(AsyncEndpointRedeliveryErrorHandlerNonBlockedDelayTest.class); - private static LongAdder attempt = new LongAdder(); + private static final LongAdder attempt = new LongAdder(); private static String beforeThreadName; private static String afterThreadName; diff --git a/core/camel-management/src/test/java/org/apache/camel/management/LoadTimerTest.java b/core/camel-management/src/test/java/org/apache/camel/management/LoadTimerTest.java index 200bc34f1e2..8d495d71c1f 100644 --- a/core/camel-management/src/test/java/org/apache/camel/management/LoadTimerTest.java +++ b/core/camel-management/src/test/java/org/apache/camel/management/LoadTimerTest.java @@ -65,7 +65,7 @@ public class LoadTimerTest extends ContextTestSupport { private static class TestLoadAware implements TimerListener { - LongAdder counter = new LongAdder(); + final LongAdder counter = new LongAdder(); final LoadTriplet load = new LoadTriplet(); @Override diff --git a/core/camel-support/src/test/java/org/apache/camel/support/task/TaskTestSupport.java b/core/camel-support/src/test/java/org/apache/camel/support/task/TaskTestSupport.java index a0cd53bbb2a..3144ba23161 100644 --- a/core/camel-support/src/test/java/org/apache/camel/support/task/TaskTestSupport.java +++ b/core/camel-support/src/test/java/org/apache/camel/support/task/TaskTestSupport.java @@ -25,7 +25,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; public class TaskTestSupport { protected final int maxIterations = 5; - protected LongAdder taskCount = new LongAdder(); + protected final LongAdder taskCount = new LongAdder(); protected boolean booleanSupplier() { taskCount.increment();