Re: [PR] Ref#271: Add missing bundles for camel-amqp and camel-activemq [camel-karaf]

[via GitHub]

jbonofre commented on code in PR #272:
URL: https://github.com/apache/camel-karaf/pull/272#discussion_r1589098637


##########
features/src/main/feature/camel-features.xml:
##########
@@ -285,11 +285,18 @@
 
     <feature name='camel-activemq' version='${project.version}' 
start-level='50'>
         <feature version='${camel.osgi.version.range}'>camel-jms</feature>
+        <bundle 
dependency='true'>mvn:org.apache.activemq/activemq-client-jakarta/${activemq-version}</bundle>

Review Comment:
   NB: when upgrading to ActiveMQ 6.x, we will be able to use `activemq-client` 
(`activemq-client-jakarta` is just for transition on 5.18.x).



##########
features/src/main/feature/camel-features.xml:
##########
@@ -285,11 +285,18 @@
 
     <feature name='camel-activemq' version='${project.version}' 
start-level='50'>
         <feature version='${camel.osgi.version.range}'>camel-jms</feature>
+        <bundle 
dependency='true'>mvn:org.apache.activemq/activemq-client-jakarta/${activemq-version}</bundle>
+        <bundle 
dependency='true'>mvn:org.fusesource.hawtbuf/hawtbuf/1.11</bundle>

Review Comment:
   This one should be optional in the import. I would remove it and define 
optional in the wrapper.



##########
features/src/main/feature/camel-features.xml:
##########
@@ -1237,6 +1244,16 @@
     <feature name="camel-jms" version="${project.version}" start-level="50">
         <feature version='${camel.osgi.version.range}'>camel-core</feature>
         <feature version="${camel.osgi.spring.version}">spring-jms</feature>
+        <!-- The SMX bundle of Spring JMS doesn't contain micrometer as part 
of its import packages, see https://issues.apache.org/jira/browse/SM-5706,
+            so we need to override the imports by wrapping the bundle until it 
is fixed in the SMX bundle project and in Karaf.
+            The Bundle-Version is updated by 
Bundle-Version=${spring-version}.2 so that the updated bundle is used
+            instead of the one provided by Karaf.
+        -->
+        <!-- Workaround START -->
+        <bundle 
start-level="30">wrap:mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jms/${spring-version}_1$overwrite=merge&amp;Import-package=io.micrometer;resolution:=optional,*;resolution:=optional&amp;Bundle-Version=${spring-version}.2</bundle>

Review Comment:
   That will be fix in the next SMX bundles releases (I will prepare the 
release during the week end).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org