squakez commented on code in PR #5488:
URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595277277
##########
pkg/trait/jvm.go:
##########
@@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool,
*TraitCondition, error) {
if e.CamelCatalog == nil {
return false,
NewIntegrationConditionPlatformDisabledCatalogMissing(), nil
}
+
+ if t.Jar == "" && e.IntegrationKit != nil {
+ executableArtifact := e.IntegrationKit.GetExecutableArtifact()
+ if executableArtifact == nil {
+ return false, nil, fmt.Errorf("could not locate any
executable among Integration Kit %s artifacts", e.IntegrationKit.Name)
+ }
+ t.Jar = executableArtifact.Target
Review Comment:
No, it's a pertinent question. I am still working on the backward
compatibility. I was thinking to comment that part and forcefully add
"dependencies/quarkus-run.jar" which should be kept until we support V2.3. As
this part is also overlapping the development I am doing to support the trait
for "sourceless" Integration is something I'll need to still do. Since it's
still a draft PR, consider that certain details are missing. However,
definetely good to have early feedback, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
