jamesnetherton commented on code in PR #6091:
URL: https://github.com/apache/camel-quarkus/pull/6091#discussion_r1601766075
##########
integration-tests-support/kafka/src/main/java/org/apache/camel/quarkus/test/support/kafka/KafkaTestResource.java:
##########
@@ -18,38 +18,96 @@
import java.util.Collections;
import java.util.Map;
+import java.util.function.Function;
+import com.github.dockerjava.api.exception.NotFoundException;
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
import io.strimzi.test.container.StrimziKafkaContainer;
+import org.apache.camel.quarkus.test.FipsModeUtil;
import org.eclipse.microprofile.config.ConfigProvider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.testcontainers.containers.ContainerFetchException;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.images.builder.ImageFromDockerfile;
import org.testcontainers.utility.TestcontainersConfiguration;
public class KafkaTestResource implements QuarkusTestResourceLifecycleManager {
protected static final String KAFKA_IMAGE_NAME =
ConfigProvider.getConfig().getValue("kafka.container.image", String.class);
private static final Logger LOGGER =
LoggerFactory.getLogger(KafkaTestResource.class);
private StrimziKafkaContainer container;
+ private GenericContainer j17container;
@Override
public Map<String, String> start() {
LOGGER.info(TestcontainersConfiguration.getInstance().toString());
try {
- container = new StrimziKafkaContainer(KAFKA_IMAGE_NAME)
- /* Added container startup logging because of
https://github.com/apache/camel-quarkus/issues/2461 */
- .withLogConsumer(frame ->
System.out.print(frame.getUtf8String()))
- .waitForRunning();
-
- container.start();
+ startContainer(KAFKA_IMAGE_NAME, name -> new
StrimziKafkaContainer(name));
return Collections.singletonMap("camel.component.kafka.brokers",
container.getBootstrapServers());
} catch (Exception e) {
throw new RuntimeException(e);
}
}
+ public String start(Function<String, StrimziKafkaContainer>
containerSupplier) {
+ LOGGER.info(TestcontainersConfiguration.getInstance().toString());
+
+ //if FIPS environment is present, custom container using J17 has to
used because:
+ // Password-based encryption support in FIPs mode was implemented in
the Red Hat build of OpenJDK 17 update 4
+ if (FipsModeUtil.isFipsMode()) {
+ //custom image should be cached for the next usages with following
id
+ String customImageName = "camel-quarkus-test-custom-" +
KAFKA_IMAGE_NAME.replaceAll("[\\./]", "-");
+
+ try {
+ //in case that the image is not accessible, fetch exception is
thrown
+ startContainer(customImageName, containerSupplier);
+ } catch (ContainerFetchException e) {
+ if (e.getCause() instanceof NotFoundException) {
+ LOGGER.info("Custom image for kafka (%s) does not exist.
Has to be created.", customImageName);
+
+ //start of the customized container will create the image
+ //it is not possible to customize existing
StrimziKafkaContainer. Testcontainer API doe not allow
+ //to customize the image.
+ // This workaround can be removed once the strimzi
container with openjdk 17 is released.
+ // According to
https://strimzi.io/blog/2023/01/25/running-apache-kafka-on-fips-enabled-kubernetes-cluster/
+ // image should exist
+ j17container = new GenericContainer(
+ new ImageFromDockerfile(customImageName, false)
+ .withDockerfileFromBuilder(builder ->
builder
+
.from("quay.io/strimzi-test-container/test-container:latest-kafka-3.2.1")
+ .env("JAVA_HOME",
"/usr/lib/jvm/jre-17")
+ .env("PATH",
"/usr/lib/jvm/jre-17/bin:$PATH")
Review Comment:
Here's the reason I guess:
https://github.com/strimzi/test-container-images/blob/main/images/base/Dockerfile#L6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
