This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 24d24933469057311d75e2aba6709e40b1567b59 Author: Otavio R. Piske <angusyo...@gmail.com> AuthorDate: Fri May 24 19:57:29 2024 +0200 (chores) camel-core: fix overly complex conversion to String Signed-off-by: Otavio R. Piske <angusyo...@gmail.com> --- .../java/org/apache/camel/component/bean/BeanConcurrentTest.java | 2 +- .../apache/camel/component/bean/BeanExpressionConcurrentTest.java | 2 +- .../camel/component/bean/issues/BeanVsProcessorPerformanceTest.java | 4 ++-- .../apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java | 2 +- .../java/org/apache/camel/impl/DefaultEndpointRegistryTest.java | 2 +- .../java/org/apache/camel/issues/SplitterParallelIssueTest.java | 2 +- .../java/org/apache/camel/processor/PipelineConcurrentTest.java | 2 +- .../aggregator/AggregateConcurrentPerCorrelationKeyTest.java | 2 +- .../camel/processor/aggregator/AggregateMultipleSourceTest.java | 6 +++--- .../aggregator/DistributedConcurrentPerCorrelationKeyTest.java | 4 ++-- .../processor/aggregator/DistributedOptimisticLockFailingTest.java | 4 ++-- .../src/test/java/org/apache/camel/util/OrderedComparatorTest.java | 2 +- 12 files changed, 17 insertions(+), 17 deletions(-) diff --git a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java index 3316c3cbe48..40ea5a403fa 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanConcurrentTest.java @@ -37,7 +37,7 @@ public class BeanConcurrentTest extends ContextTestSupport { // start from 1000 to be 4 digit always (easier to string compare) for (int i = 1000; i < 2000; i++) { - template.sendBody("seda:foo", "" + i); + template.sendBody("seda:foo", Integer.toString(i)); } context.getRouteController().startRoute("foo"); diff --git a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java index 2670f47be83..559df13b55b 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/bean/BeanExpressionConcurrentTest.java @@ -37,7 +37,7 @@ public class BeanExpressionConcurrentTest extends ContextTestSupport { // start from 1000 to be 4 digit always (easier to string compare) for (int i = 1000; i < 2000; i++) { - template.sendBody("seda:foo", "" + i); + template.sendBody("seda:foo", Integer.toString(i)); } context.getRouteController().startRoute("foo"); diff --git a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java index 2286c6de58a..a48ebe16a46 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/bean/issues/BeanVsProcessorPerformanceTest.java @@ -43,7 +43,7 @@ public class BeanVsProcessorPerformanceTest extends ContextTestSupport { StopWatch watch = new StopWatch(); for (int i = 0; i < size; i++) { - Object out = template.requestBody("direct:a", "" + i); + Object out = template.requestBody("direct:a", Integer.toString(i)); assertEquals("Bye " + i, out); } @@ -55,7 +55,7 @@ public class BeanVsProcessorPerformanceTest extends ContextTestSupport { StopWatch watch = new StopWatch(); for (int i = 0; i < size; i++) { - Object out = template.requestBody("direct:b", "" + i); + Object out = template.requestBody("direct:b", Integer.toString(i)); assertEquals("Bye " + i, out); } diff --git a/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java b/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java index 13659bcda2e..0c347b06da7 100644 --- a/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/component/seda/SameSedaQueueSizeAndNoSizeTest.java @@ -33,7 +33,7 @@ public class SameSedaQueueSizeAndNoSizeTest extends ContextTestSupport { @Test public void testSameQueue() { for (int i = 0; i < 100; i++) { - template.sendBody("seda:foo", "" + i); + template.sendBody("seda:foo", Integer.toString(i)); } CamelExecutionException e = assertThrows(CamelExecutionException.class, diff --git a/core/camel-core/src/test/java/org/apache/camel/impl/DefaultEndpointRegistryTest.java b/core/camel-core/src/test/java/org/apache/camel/impl/DefaultEndpointRegistryTest.java index cd07fbfdb9b..ccbb1604e32 100644 --- a/core/camel-core/src/test/java/org/apache/camel/impl/DefaultEndpointRegistryTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/impl/DefaultEndpointRegistryTest.java @@ -90,7 +90,7 @@ public class DefaultEndpointRegistryTest { FluentProducerTemplate template = ctx.createFluentProducerTemplate(); for (int i = 0; i < 100; i++) { - template.withBody("Hello").withHeader("foo", "" + i).to("direct:start").send(); + template.withBody("Hello").withHeader("foo", Integer.toString(i)).to("direct:start").send(); } Awaitility.await().untilAsserted(() -> { diff --git a/core/camel-core/src/test/java/org/apache/camel/issues/SplitterParallelIssueTest.java b/core/camel-core/src/test/java/org/apache/camel/issues/SplitterParallelIssueTest.java index de16d152ce3..20d74e1dc9c 100644 --- a/core/camel-core/src/test/java/org/apache/camel/issues/SplitterParallelIssueTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/issues/SplitterParallelIssueTest.java @@ -43,7 +43,7 @@ public class SplitterParallelIssueTest extends ContextTestSupport { final int num = i; new Thread(new Runnable() { public void run() { - template.sendBody("direct:start", "" + num); + template.sendBody("direct:start", Integer.toString(num)); } }).start(); } diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/PipelineConcurrentTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/PipelineConcurrentTest.java index 6eec1aad361..94ce8f366ef 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/PipelineConcurrentTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/PipelineConcurrentTest.java @@ -55,7 +55,7 @@ public class PipelineConcurrentTest extends ContextTestSupport { } catch (InterruptedException e) { // ignore } - template.sendBody(uri, "" + (start + i)); + template.sendBody(uri, Integer.toString(start + i)); } } }); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateConcurrentPerCorrelationKeyTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateConcurrentPerCorrelationKeyTest.java index 275936349a2..49d88243a9e 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateConcurrentPerCorrelationKeyTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateConcurrentPerCorrelationKeyTest.java @@ -44,7 +44,7 @@ public class AggregateConcurrentPerCorrelationKeyTest extends ContextTestSupport final int count = i; tasks.add(new Callable<Object>() { public Object call() { - template.sendBodyAndHeader(uri, "" + count, "id", id); + template.sendBodyAndHeader(uri, Integer.toString(count), "id", id); return null; } }); diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateMultipleSourceTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateMultipleSourceTest.java index c49e67660da..aa24f9ec695 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateMultipleSourceTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateMultipleSourceTest.java @@ -33,11 +33,11 @@ public class AggregateMultipleSourceTest extends ContextTestSupport { for (int i = 0; i < 40; i++) { if (i % 2 == 0) { - template.sendBodyAndHeader("seda:foo", "" + i, "type", "A"); + template.sendBodyAndHeader("seda:foo", Integer.toString(i), "type", "A"); } else if (i % 5 == 0) { - template.sendBodyAndHeader("seda:bar", "" + i, "type", "A"); + template.sendBodyAndHeader("seda:bar", Integer.toString(i), "type", "A"); } else { - template.sendBodyAndHeader("seda:baz", "" + i, "type", "A"); + template.sendBodyAndHeader("seda:baz", Integer.toString(i), "type", "A"); } } diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedConcurrentPerCorrelationKeyTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedConcurrentPerCorrelationKeyTest.java index ce55e76abe4..a20f63640ea 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedConcurrentPerCorrelationKeyTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedConcurrentPerCorrelationKeyTest.java @@ -69,9 +69,9 @@ public class DistributedConcurrentPerCorrelationKeyTest extends AbstractDistribu private Object sendTask(int choice, int count, int id) { String uri = "direct:start"; if (choice == 0) { - template.sendBodyAndHeader(uri, "" + count, "id", id); + template.sendBodyAndHeader(uri, Integer.toString(count), "id", id); } else { - template2.sendBodyAndHeader(uri, "" + count, "id", id); + template2.sendBodyAndHeader(uri, Integer.toString(count), "id", id); } return null; } diff --git a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedOptimisticLockFailingTest.java b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedOptimisticLockFailingTest.java index 7f12cc9f4ff..89814f185e8 100644 --- a/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedOptimisticLockFailingTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedOptimisticLockFailingTest.java @@ -130,9 +130,9 @@ public class DistributedOptimisticLockFailingTest extends AbstractDistributedTes private Object sendTask(int choice, int count, int id) { if (choice == 0) { - template.sendBodyAndHeader("direct:everysecondone", "" + count, "id", id); + template.sendBodyAndHeader("direct:everysecondone", Integer.toString(count), "id", id); } else { - template2.sendBodyAndHeader("direct:everysecondone", "" + count, "id", id); + template2.sendBodyAndHeader("direct:everysecondone", Integer.toString(count), "id", id); } return null; } diff --git a/core/camel-core/src/test/java/org/apache/camel/util/OrderedComparatorTest.java b/core/camel-core/src/test/java/org/apache/camel/util/OrderedComparatorTest.java index c2bab00b435..5977c2965b4 100644 --- a/core/camel-core/src/test/java/org/apache/camel/util/OrderedComparatorTest.java +++ b/core/camel-core/src/test/java/org/apache/camel/util/OrderedComparatorTest.java @@ -194,7 +194,7 @@ public class OrderedComparatorTest { @Override public String toString() { - return "" + order; + return Integer.toString(order); } } }