This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push: new cc85e529b1d CAMEL-20722 new log entry to log the exception (#14344) cc85e529b1d is described below commit cc85e529b1d0dced0999bd65b0fe96c389c4029d Author: Jang-Vijay Singh <jvs...@gmail.com> AuthorDate: Tue Jun 4 20:21:13 2024 +0100 CAMEL-20722 new log entry to log the exception (#14344) * CAMEL-20722 - add log.error for original exception Original exception is currently not being logged, as another exception gets raised from the next line within the catch block * CAMEL-20722 - removed blank newline + added defensive if condition * CAMEL-20722 - removed whitespace before 'Unexpected' --- .../apache/camel/test/infra/kafka/services/KafkaService.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test-infra/camel-test-infra-kafka/src/test/java/org/apache/camel/test/infra/kafka/services/KafkaService.java b/test-infra/camel-test-infra-kafka/src/test/java/org/apache/camel/test/infra/kafka/services/KafkaService.java index 38bc88bc533..962843d7282 100644 --- a/test-infra/camel-test-infra-kafka/src/test/java/org/apache/camel/test/infra/kafka/services/KafkaService.java +++ b/test-infra/camel-test-infra-kafka/src/test/java/org/apache/camel/test/infra/kafka/services/KafkaService.java @@ -42,11 +42,12 @@ public interface KafkaService extends TestService, BeforeTestExecutionCallback, initialize(); } catch (Exception e) { Logger log = LoggerFactory.getLogger(KafkaService.class); - - final Object o = extensionContext.getTestInstance().get(); - log.error("Failed to initialize service {} for test {} on ({})", this.getClass().getSimpleName(), - extensionContext.getDisplayName(), o.getClass().getName()); - + log.error("Unexpected error in {}: {} {} ", this.getClass().getSimpleName(), e.getMessage(), e.getCause()); + if (extensionContext != null && extensionContext.getTestInstance() != null) { + Object o = extensionContext.getTestInstance().get(); + log.error("Failed to initialize service {} for test {} on ({})", this.getClass().getSimpleName(), + extensionContext.getDisplayName(), o.getClass().getName()); + } throw e; } }