christophd commented on PR #5597: URL: https://github.com/apache/camel-k/pull/5597#issuecomment-2157996246
@squakez all tests are green now. I have also added some E2E test to verify the different Knative trigger possibilities (e.g. no filter, filter by ce-source and so on) In terms of design considerations I think the binding provider is meant to create/configure the integration from a Pipe that may reference other K8s resources. The binding provider translates these resource references into Camel components and the YAML route DSL that is being used in the integration. The traits are part of the integration so the binding provider has access to it, which is not a new design introduced in this PR. We can open a new issue to discuss this current design if you want. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
