squakez commented on code in PR #16064:
URL: https://github.com/apache/camel/pull/16064#discussion_r1813070646
##########
components/camel-knative/camel-knative-component/src/main/docs/knative-component.adoc:
##########
@@ -137,13 +137,21 @@ RouteBuilder.addRoutes(context, b -> {
<1> set the location of the `Knative Environment` file
<2> expose knative service
-=== Using custom Knative Transport
+You can also use property based component configuration to set the `Knative
Environemnt` configuration file.
-As today the component only support `http` as transport as it is the only
supported protocol on Knative side but the transport is pluggable by
implementing the following interface:
+.application.properties
+[source,properties]
+----
+camel.component.knative.environmentPath=classpath:knative.json
Review Comment:
Is this anyhow changing any previous behavior. I am not into details of the
implementations, just wondering if by any chance we'll be introducing any
breaking compatibility. I recall we gave the possibility to initialize
environment from an environment variable as well, but I may be making confusion.
##########
components/camel-knative/camel-knative-component/src/main/docs/knative-component.adoc:
##########
@@ -137,13 +137,21 @@ RouteBuilder.addRoutes(context, b -> {
<1> set the location of the `Knative Environment` file
<2> expose knative service
-=== Using custom Knative Transport
+You can also use property based component configuration to set the `Knative
Environemnt` configuration file.
Review Comment:
```suggestion
You can also use property based component configuration to set the `Knative
Environment` configuration file.
```
##########
components/camel-knative/camel-knative-http/src/main/java/org/apache/camel/component/knative/http/TrustAllOptions.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.knative.http;
+
+import java.security.KeyStore;
+import java.security.Provider;
+import java.security.cert.X509Certificate;
+import java.util.function.Function;
+
+import javax.net.ssl.ManagerFactoryParameters;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.TrustManagerFactory;
+import javax.net.ssl.TrustManagerFactorySpi;
+import javax.net.ssl.X509TrustManager;
+
+import io.vertx.core.Vertx;
+import io.vertx.core.net.TrustOptions;
+
+/**
+ * Trust options for trusting all client and server certificates. Do not use
in production environments but primarily in
+ * test environments. Implementation is heavily based on the Quarkus TLS
registry implementation.
Review Comment:
How would this behave on main or Spring Boot runtimes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
