davsclaus commented on code in PR #16084:
URL: https://github.com/apache/camel/pull/16084#discussion_r1815081192
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/test/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/PodLogsTest.java:
##########
@@ -33,7 +33,8 @@ public void shouldHandlePodNotFound() throws Exception {
PodLogs command = createCommand();
command.name = "mickey-mouse";
command.maxWaitAttempts = 2; // total timeout of 4 seconds
- command.doCall();
+ int exit = command.doCall();
+ Assertions.assertEquals(1, exit);
Review Comment:
Just wonder why exit code 1 is expected, is the command supposed to fail
somehow ? If so maybe add a code comment to tell this reason so we wont get
confused later looking back at this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
