mikey-austin commented on code in PR #16650:
URL: https://github.com/apache/camel/pull/16650#discussion_r1896823142
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/Kinesis2Configuration.java:
##########
@@ -47,6 +51,9 @@ public class Kinesis2Configuration implements Cloneable {
@UriParam(description = "Amazon Kinesis client to use for all requests for
this endpoint")
@Metadata(label = "advanced", autowired = true)
private KinesisClient amazonKinesisClient;
+ @UriParam(description = "Amazon Kinesis async client to use for all
requests for this endpoint that require an async client")
Review Comment:
I'm currently evaluating this for a use case in production. It has been
working pretty well so far, but I am still yet to do some serious load testing,
which will probably happen after New Years. One possible improvement I thought
of was around potentially injecting a custom AWS credential provider
implementation and make use of the library client instantiation. It was a more
involved patch, so for now I went with the current approach which also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
